Commit f2d1aa6e authored by Ken Buchanan's avatar Ken Buchanan Committed by Commit Bot

[Secure Payment Confirmation] Enable browser tests on Windows

The previously observed crashes no longer repro for me in tests or
exercising the API in browser. The crash had been very reliable before.

This CL enables the tests to see if the issue has somehow become
resolved.

Fixed: 1123273
Change-Id: Id23ef5ba460267cd013eeaa533e1a8caec7330a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490512
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819559}
parent f346197c
...@@ -316,24 +316,8 @@ class SecurePaymentConfirmationCreationTest ...@@ -316,24 +316,8 @@ class SecurePaymentConfirmationCreationTest
} }
}; };
#if defined(OS_WIN)
// TODO(kenrb): This experiment is currently only available on Mac, but this
// test should work on all non-Android platforms. There is a Windows failure
// that still needs to be investigated.
#define MAYBE_CreatePaymentCredential DISABLED_CreatePaymentCredential
#define MAYBE_LookupPaymentCredential DISABLED_LookupPaymentCredential
#define MAYBE_ConfirmPaymentInCrossOriginIframe \
DISABLED_ConfirmPaymentInCrossOriginIframe
#define MAYBE_ChallengeIsReturned DISABLED_ChallengeIsReturned
#else
#define MAYBE_CreatePaymentCredential CreatePaymentCredential
#define MAYBE_LookupPaymentCredential LookupPaymentCredential
#define MAYBE_ConfirmPaymentInCrossOriginIframe \
ConfirmPaymentInCrossOriginIframe
#define MAYBE_ChallengeIsReturned ChallengeIsReturned
#endif
IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
MAYBE_CreatePaymentCredential) { CreatePaymentCredential) {
base::HistogramTester histogram_tester; base::HistogramTester histogram_tester;
ReplaceFidoDiscoveryFactory(); ReplaceFidoDiscoveryFactory();
NavigateTo("a.com", "/secure_payment_confirmation.html"); NavigateTo("a.com", "/secure_payment_confirmation.html");
...@@ -349,7 +333,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, ...@@ -349,7 +333,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
} }
IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
MAYBE_LookupPaymentCredential) { LookupPaymentCredential) {
ReplaceFidoDiscoveryFactory(); ReplaceFidoDiscoveryFactory();
NavigateTo("a.com", "/secure_payment_confirmation.html"); NavigateTo("a.com", "/secure_payment_confirmation.html");
std::string credentialIdentifier = std::string credentialIdentifier =
...@@ -379,7 +363,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, ...@@ -379,7 +363,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
} }
IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
MAYBE_ConfirmPaymentInCrossOriginIframe) { ConfirmPaymentInCrossOriginIframe) {
NavigateTo("a.com", "/secure_payment_confirmation.html"); NavigateTo("a.com", "/secure_payment_confirmation.html");
ReplaceFidoDiscoveryFactory(); ReplaceFidoDiscoveryFactory();
std::string credentialIdentifier = std::string credentialIdentifier =
...@@ -404,7 +388,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, ...@@ -404,7 +388,7 @@ IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
} }
IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest, IN_PROC_BROWSER_TEST_F(SecurePaymentConfirmationCreationTest,
MAYBE_ChallengeIsReturned) { ChallengeIsReturned) {
NavigateTo("a.com", "/secure_payment_confirmation.html"); NavigateTo("a.com", "/secure_payment_confirmation.html");
ReplaceFidoDiscoveryFactory(); ReplaceFidoDiscoveryFactory();
std::string credentialIdentifier = std::string credentialIdentifier =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment