Commit f2e2b06d authored by Yuwei Huang's avatar Yuwei Huang Committed by Commit Bot

Blacklist grpc_core::InlinedVector for CFI cast check

grpc_core::InlinedVector has a few (reinterpret|static)_casts that look
benign but will trigger CFI bad cast check. I've tried to suppress the
check by adding "-fno-sanitize=cfi-..." when building the gRPC lib
(http://crrev.com/c/1660194), but it doesn't seem to have any effect on
the canary ChromeOS build. As suggested by pcc@, this CL blacklists the
whole inlined_vector.h file for CFI cast check.

For longer term, we will need to fix InlinedVector to prevent it from
casting the element before initializing it. This is tracked in github.

Bug: 972108
Change-Id: Ic90631f9e66d15e1a3c8d073c99bfb69a6400103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665554Reviewed-by: default avatarPeter Collingbourne <pcc@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#670300}
parent fd0f9b34
......@@ -29,6 +29,9 @@ fun:*internal_default_instance*
# CAtlArray<T> casts to uninitialized T*.
src:*atlcoll.h
# https://github.com/grpc/grpc/issues/19375
src:*third_party/grpc/src/src/core/lib/gprpp/inlined_vector.h
#############################################################################
# Base class's constructor accesses a derived class.
......@@ -49,7 +52,7 @@ fun:*ThreadSafeRefCountedGarbageCollected*makeKeepAlive*
fun:*DatabaseContext*contextDestroyed*
# FIXME: Cannot handle template function LifecycleObserver<>::setContext,
# so exclude source file for now.
# so exclude source file for now.
src:*lifecycle_observer.h*
#############################################################################
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment