Commit f2ece56c authored by Xing Liu's avatar Xing Liu Committed by Chromium LUCI CQ

Read later: Don't close bookmark UI after opening a reading list page.

Keep the bookmark UI reading list page open after the user open a
reading list page in CCT.

Bug: 1163719
Change-Id: Ibfdd1045301bcf7de5dcb301877f2b4394181bb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639220Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845370}
parent d9b44586
...@@ -28,6 +28,7 @@ import org.chromium.chrome.browser.profiles.Profile; ...@@ -28,6 +28,7 @@ import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager; import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
import org.chromium.chrome.browser.ui.native_page.BasicNativePage; import org.chromium.chrome.browser.ui.native_page.BasicNativePage;
import org.chromium.components.bookmarks.BookmarkId; import org.chromium.components.bookmarks.BookmarkId;
import org.chromium.components.bookmarks.BookmarkType;
import org.chromium.components.browser_ui.util.ConversionUtils; import org.chromium.components.browser_ui.util.ConversionUtils;
import org.chromium.components.browser_ui.widget.dragreorder.DragStateDelegate; import org.chromium.components.browser_ui.widget.dragreorder.DragStateDelegate;
import org.chromium.components.browser_ui.widget.selectable_list.SelectableListLayout; import org.chromium.components.browser_ui.widget.selectable_list.SelectableListLayout;
...@@ -494,8 +495,13 @@ public class BookmarkManager ...@@ -494,8 +495,13 @@ public class BookmarkManager
@Override @Override
public void openBookmark(BookmarkId bookmark) { public void openBookmark(BookmarkId bookmark) {
if (BookmarkUtils.openBookmark( if (!BookmarkUtils.openBookmark(
mContext, mOpenBookmarkComponentName, mBookmarkModel, bookmark)) { mContext, mOpenBookmarkComponentName, mBookmarkModel, bookmark)) {
return;
}
// Close bookmark UI. Keep the reading list page open.
if (bookmark != null && bookmark.getType() != BookmarkType.READING_LIST) {
BookmarkUtils.finishActivityOnPhone(mContext); BookmarkUtils.finishActivityOnPhone(mContext);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment