IDL parser: Parse special comments as AST nodes
Tests in tools/idl_parser are broken as of [1] because the current IDL parser discards comments but tests assumed that there are comment nodes which contain test expectations. This CL is basically a revert of [1] with following modifications: - Introduce SpecialComments instead of Comments - SpecialComments are Javadoc-style comment (/** ... */) and they are parsed to AST nodes - Normal comments (C/C++ style; /* ... */ and // ...) are still ignored The reason to introduce SpecialComments: If we treat normal comments as tokens and parse them as AST nodes, we have to add a lot of custom rules to the parser, which will mess up the parser. [1] https://chromium-review.googlesource.com/c/544424 BUG=740524 Change-Id: I872b6c19e6b844859bbcaa48c828decda36cb300 Reviewed-on: https://chromium-review.googlesource.com/569940Reviewed-by:Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#486629}
Showing
Please register or sign in to comment