Commit f319fc79 authored by Victor Miura's avatar Victor Miura Committed by Commit Bot

Revert "Reland "[perf] Add browse:media:tumblr:2018 system health story""

This reverts commit 65fa1aac.

Reason for revert: Suspect this broke linkedin login credentials.  BUG=894454

Original change's description:
> Reland "[perf] Add browse:media:tumblr:2018 system health story"
> 
> This reverts commit c64ae579.
> 
> Original change's description:
> > [perf] Add browse:media:tumblr:2018 system health story
> >
> > This also add a login helper for tumblr and updates credentials.json
> >
> > Bug: 878390
> > Change-Id: Iba56faf550cb638692899326b217347e04be9932
> > Reviewed-on: https://chromium-review.googlesource.com/c/1256883
> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#596763}
> 
> Change-Id: Ib40cc4b8c7f2fe4d23fe3effd285122e703d1601
> Reviewed-on: https://chromium-review.googlesource.com/c/1264382
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598715}

TBR=ulan@chromium.org,perezju@chromium.org,nednguyen@google.com

Change-Id: I8edcf9a3ea4fc2b9fd72cdd5c9f4545bf3a81ca3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1278466Reviewed-by: default avatarVictor Miura <vmiura@chromium.org>
Commit-Queue: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599018}
parent 485de651
38f6afad3baf96684730bf307244fc7fa6bd6f7d 62bb07f739452c44b3618b9b3f3de6251bf73322
\ No newline at end of file \ No newline at end of file
...@@ -12,9 +12,6 @@ ...@@ -12,9 +12,6 @@
"browse:media:tumblr": { "browse:media:tumblr": {
"DEFAULT": "system_health_desktop_036.wprgo" "DEFAULT": "system_health_desktop_036.wprgo"
}, },
"browse:media:tumblr:2018": {
"DEFAULT": "system_health_desktop_55cb9dd713.wprgo"
},
"browse:media:youtube": { "browse:media:youtube": {
"DEFAULT": "system_health_desktop_026.wprgo", "DEFAULT": "system_health_desktop_026.wprgo",
"linux": "system_health_desktop_026.wprgo", "linux": "system_health_desktop_026.wprgo",
......
55cb9dd71364f014e51f4ed50207ac91820a555d
\ No newline at end of file
# Copyright 2018 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from page_sets.login_helpers import login_utils
def LoginDesktopAccount(action_runner, credential,
credentials_path=login_utils.DEFAULT_CREDENTIAL_PATH):
"""Logs in into a Tumblr account."""
account_name, password = login_utils.GetAccountNameAndPassword(
credential, credentials_path=credentials_path)
action_runner.Navigate('https://www.tumblr.com/login')
login_utils.InputWithSelector(
action_runner, account_name, 'input[type=email]')
next_button = '.signup_determine_btn'
enter_password_button = '.forgot_password_link'
action_runner.WaitForElement(selector=next_button)
action_runner.ClickElement(selector=next_button)
action_runner.Wait(1)
action_runner.WaitForElement(selector=enter_password_button)
action_runner.ClickElement(selector=enter_password_button)
action_runner.Wait(1)
login_utils.InputWithSelector(
action_runner, password, 'input[type=password]')
action_runner.Wait(1)
action_runner.WaitForElement(selector=next_button)
action_runner.ClickElement(selector=next_button)
...@@ -15,7 +15,6 @@ from page_sets.system_health import system_health_story ...@@ -15,7 +15,6 @@ from page_sets.system_health import system_health_story
from page_sets.login_helpers import facebook_login from page_sets.login_helpers import facebook_login
from page_sets.login_helpers import pinterest_login from page_sets.login_helpers import pinterest_login
from page_sets.login_helpers import tumblr_login
from telemetry.util import js_template from telemetry.util import js_template
...@@ -593,28 +592,6 @@ class TumblrDesktopStory(_MediaBrowsingStory): ...@@ -593,28 +592,6 @@ class TumblrDesktopStory(_MediaBrowsingStory):
action_runner.MouseClick(selector='#tumblr_lightbox_center_image') action_runner.MouseClick(selector='#tumblr_lightbox_center_image')
action_runner.Wait(1) # To make browsing more realistic. action_runner.Wait(1) # To make browsing more realistic.
class TumblrDesktopStory2018(_MediaBrowsingStory):
NAME = 'browse:media:tumblr:2018'
URL = 'https://tumblr.com/search/gifs'
ITEM_SELECTOR = '.post_media'
IS_SINGLE_PAGE_APP = True
ITEMS_TO_VISIT = 8
INCREMENT_INDEX_AFTER_EACH_ITEM = True
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
TAGS = [story_tags.YEAR_2018]
def _Login(self, action_runner):
tumblr_login.LoginDesktopAccount(action_runner, 'tumblr')
action_runner.Wait(3)
def _ViewMediaItem(self, action_runner, index):
super(TumblrDesktopStory2018, self)._ViewMediaItem(action_runner, index)
action_runner.WaitForElement(selector='#tumblr_lightbox')
action_runner.MouseClick(selector='#tumblr_lightbox')
action_runner.Wait(1) # To make browsing more realistic.
class PinterestDesktopStory(_MediaBrowsingStory): class PinterestDesktopStory(_MediaBrowsingStory):
NAME = 'browse:media:pinterest' NAME = 'browse:media:pinterest'
URL = 'https://pinterest.com' URL = 'https://pinterest.com'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment