[SendTabToSelf] Move iOS activity to 2nd from the left.

The Send to your Devices activity should be offered right next to the
copy activity.

Bug: 966523
Change-Id: I2e8855fbd0894ed6ff7499f55a8cee8eca4e4a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627657
Auto-Submit: sebsg <sebsg@chromium.org>
Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662852}

ios/chrome/browser/ui/activity_services/activity_service_controller.mm

@@ -263,18 +263,18 @@ NSString* const kActivityServicesSnackbarCategory =
       addObject:[[CopyActivity alloc] initWithURL:data.shareURL]];
 
   if (data.shareURL.SchemeIsHTTPOrHTTPS()) {
-    ReadingListActivity* readingListActivity =
-        [[ReadingListActivity alloc] initWithURL:data.shareURL
-                                           title:data.title
-                                      dispatcher:dispatcher];
-    [applicationActivities addObject:readingListActivity];
-
     if (canSendTabToSelf) {
       SendTabToSelfActivity* sendTabToSelfActivity =
           [[SendTabToSelfActivity alloc] initWithDispatcher:dispatcher];
       [applicationActivities addObject:sendTabToSelfActivity];
     }
 
+    ReadingListActivity* readingListActivity =
+        [[ReadingListActivity alloc] initWithURL:data.shareURL
+                                           title:data.title
+                                      dispatcher:dispatcher];
+    [applicationActivities addObject:readingListActivity];
+
     if (bookmarkModel) {
       BOOL bookmarked = bookmarkModel->loaded() &&
                         bookmarkModel->IsBookmarked(data.visibleURL);

ios/chrome/browser/ui/activity_services/activity_service_controller_unittest.mm

@@ -867,6 +867,10 @@ TEST_F(ActivityServiceControllerTest, SendTabToSelfActivity) {
   ASSERT_EQ(6U, [items count]);
   EXPECT_TRUE(ArrayContainsObjectOfClass(items, [SendTabToSelfActivity class]));
 
+  // When the activity is offered, it should be the second one from the left.
+  UIActivity* activity = [items objectAtIndex:1];
+  EXPECT_TRUE([activity isKindOfClass:[SendTabToSelfActivity class]]);
+
   // Verify searchable data with the send tab to self feature disabled.
   data = [[ShareToData alloc]
         initWithShareURL:GURL("https://chromium.org/printable")