Commit f31ede11 authored by khmel@chromium.org's avatar khmel@chromium.org Committed by Commit Bot

app_service: Fix possible crash on open native settings.

BUG=924872
TEST=None

Change-Id: I5df8485c1a978d8f7ec29516d2900445bf225244
Reviewed-on: https://chromium-review.googlesource.com/c/1435682
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: default avatarDominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626218}
parent 4b411e69
...@@ -231,6 +231,11 @@ void ArcApps::Uninstall(const std::string& app_id) { ...@@ -231,6 +231,11 @@ void ArcApps::Uninstall(const std::string& app_id) {
void ArcApps::OpenNativeSettings(const std::string& app_id) { void ArcApps::OpenNativeSettings(const std::string& app_id) {
const std::unique_ptr<ArcAppListPrefs::AppInfo> app_info = const std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
prefs_->GetApp(app_id); prefs_->GetApp(app_id);
if (!app_info) {
LOG(ERROR) << "Cannot open native settings for " << app_id
<< ". App is not found.";
return;
}
arc::ShowPackageInfo(app_info->package_name, arc::ShowPackageInfo(app_info->package_name,
arc::mojom::ShowPackageInfoPage::MAIN, arc::mojom::ShowPackageInfoPage::MAIN,
display::Screen::GetScreen()->GetPrimaryDisplay().id()); display::Screen::GetScreen()->GetPrimaryDisplay().id());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment