Skip to content

GitLab

T
tangled
Commit f3263d96 authored by Peter Mayo's avatar Peter Mayo Committed by Commit Bot
Browse files
Options

[BGPT] Allow new optimizations in layout tests 

With --enable-blink-gen-property-trees we don't repaint invisible nodes
on the compositor, so we don't need to animate it, and so the console
output is not present, nor are other animated changes.  This is arguably
better, but was being tested for naively.

This is a reland of 8e33e9d2a04d284b061e024103dd36ba07daa32d
> Change-Id: I625f85710ec803eb5f3515a95d84b4cf7d6ac2d1
> Reviewed-on: https://chromium-review.googlesource.com/1162075
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Reviewed-by: Robert Flack <flackr@chromium.org>

Bug: 855691
Change-Id: Idea876e956be546c1b35a0646de9260b9450592e
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1169932
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: default avatarRobert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582593}
parent 05768b7f
Hide whitespace changes
Inline Side-by-side
Showing with 39 additions and 13 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
View file @ f3263d96
...@@ -147,12 +147,8 @@ crbug.com/855688 transitions/opacity-transform-transitions-inside-iframe.html [ ...@@ -147,12 +147,8 @@ crbug.com/855688 transitions/opacity-transform-transitions-inside-iframe.html [
crbug.com/855688 transitions/transition-end-event-destroy-iframe.html [ Timeout ] crbug.com/855688 transitions/transition-end-event-destroy-iframe.html [ Timeout ]
crbug.com/855688 virtual/threaded/transitions/opacity-transform-transitions-inside-iframe.html [ Timeout ] crbug.com/855688 virtual/threaded/transitions/opacity-transform-transitions-inside-iframe.html [ Timeout ]
crbug.com/855688 virtual/threaded/transitions/transition-end-event-destroy-iframe.html [ Timeout ] crbug.com/855688 virtual/threaded/transitions/transition-end-event-destroy-iframe.html [ Timeout ]
crbug.com/855691 virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html [ Failure ]
crbug.com/855691 virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html [ Failure ]
crbug.com/855691 virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html [ Failure ]
crbug.com/855702 virtual/threaded/animations/composited-filter-webkit-filter.html [ Failure ] crbug.com/855702 virtual/threaded/animations/composited-filter-webkit-filter.html [ Failure ]
crbug.com/855702 virtual/threaded/animations/img-element-transform.html [ Timeout Failure Pass ] crbug.com/855702 virtual/threaded/animations/img-element-transform.html [ Timeout Failure Pass ]
crbug.com/855702 virtual/threaded/animations/compositor-independent-transform-cancel.html [ Failure ]
crbug.com/861824 virtual/threaded/fast/animationworklet/animation-worklet-inside-iframe.html [ Failure ] crbug.com/861824 virtual/threaded/fast/animationworklet/animation-worklet-inside-iframe.html [ Failure ]
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-filter-webkit-filter.html
View file @ f3263d96
...@@ -4,16 +4,19 @@ ...@@ -4,16 +4,19 @@
<style> <style>
@keyframes test { @keyframes test {
from { from {
-webkit-filter: saturate(0); -webkit-filter: saturate(0.25);
filter: none; filter: saturate(0.25);
} }
to { to {
-webkit-filter: saturate(1); -webkit-filter: saturate(0.75);
filter: none; filter: saturate(0.75);
} }
} }
#target { #target {
animation: test 1e10s; animation: test 1e3s;
height: 100px;
width: 100px;
background: green;
} }
</style> </style>
<div id="target"></div> <div id="target"></div>
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/compositor-independent-transform-cancel.html
View file @ f3263d96
<!DOCTYPE html> <!DOCTYPE html>
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<style>
#parent>div {
width: 100px;
height: 100px;
background-color: green;
}
</style>
<div id="parent"></div> <div id="parent"></div>
<script> <script>
......
third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-animate.html
View file @ f3263d96
<!DOCTYPE html> <!DOCTYPE html>
<style>
#target {
width: 100px;
height: 100px;
background-color: green;
}
</style>
<script id="simple_animate" type="text/worklet"> <script id="simple_animate" type="text/worklet">
registerAnimator("test_animator", class { registerAnimator("test_animator", class {
constructor() { constructor() {
...@@ -36,4 +42,4 @@ runInAnimationWorklet( ...@@ -36,4 +42,4 @@ runInAnimationWorklet(
}); });
} }
}); });
</script> </script>
\ No newline at end of file
third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/animation-worklet-animator-with-options.html
View file @ f3263d96
<!DOCTYPE html> <!DOCTYPE html>
<style>
#target {
width: 100px;
height: 100px;
background-color: green;
}
</style>
<script id="animate_with_options" type="text/worklet"> <script id="animate_with_options" type="text/worklet">
registerAnimator("test_animator", class { registerAnimator("test_animator", class {
......
third_party/WebKit/LayoutTests/virtual/threaded/fast/animationworklet/worklet-animation-currentTime.html
View file @ f3263d96
<!DOCTYPE html> <!DOCTYPE html>
<style>
#target {
width: 100px;
height: 100px;
background-color: green;
}
</style>
<script id="simple_animate" type="text/worklet"> <script id="simple_animate" type="text/worklet">
registerAnimator("test_animator", class { registerAnimator("test_animator", class {
...@@ -13,7 +20,7 @@ registerAnimator("test_animator", class { ...@@ -13,7 +20,7 @@ registerAnimator("test_animator", class {
} }
}); });
</script> </script>
<div id="target"></div> <div id="target" style="will-change: transform, opacity;"></div>
<script src="resources/animation-worklet-tests.js"></script> <script src="resources/animation-worklet-tests.js"></script>
<script> <script>
if (window.testRunner) { if (window.testRunner) {
...@@ -36,4 +43,4 @@ runInAnimationWorklet( ...@@ -36,4 +43,4 @@ runInAnimationWorklet(
}); });
} }
}); });
</script> </script>
\ No newline at end of file
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment