Commit f3265229 authored by yusukes's avatar yusukes Committed by Commit bot

Do not show "can't open" dialog when the disambig dialog is dismissed

BUG=b:31959560
TEST=click a link with a custom scheme, then press ESC

Review-Url: https://codereview.chromium.org/2455733004
Cr-Commit-Position: refs/heads/master@{#430306}
parent baa2708e
...@@ -204,7 +204,8 @@ bool HandleUrl(int render_process_host_id, ...@@ -204,7 +204,8 @@ bool HandleUrl(int render_process_host_id,
return false; return false;
} }
// Called when the dialog is closed. // Called when the dialog is closed. Note that once we show the UI, we should
// never show the Chrome OS' fallback dialog.
void OnIntentPickerClosed(int render_process_host_id, void OnIntentPickerClosed(int render_process_host_id,
int routing_id, int routing_id,
const GURL& url, const GURL& url,
...@@ -258,9 +259,8 @@ void OnIntentPickerClosed(int render_process_host_id, ...@@ -258,9 +259,8 @@ void OnIntentPickerClosed(int render_process_host_id,
// fall through. // fall through.
} }
case ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED: { case ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED: {
// The user didn't select any ARC activity. Show the Chrome OS dialog. // The user didn't select any ARC activity.
ShowFallbackExternalProtocolDialog(render_process_host_id, routing_id, CloseTabIfNeeded(render_process_host_id, routing_id);
url);
break; break;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment