Make two settings sections visible for ephemeral guest profiles

- Make the "You and Google" and "Auto-fill" sections visible,
when settings is based on an ephemeral guest profile.
- The notion of Ephemeral Guest profiles (go/ephemeral-guest-profiles)
is to be replacing the current guest profiles.

Bug: 1140419
Change-Id: If10584bb4a8105275c2eac8c581c7abccf545225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483753Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Huanzhong Huang <huanzhong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819350}

chrome/browser/resources/settings/page_visibility.js

@@ -48,12 +48,15 @@ export let PrivacyPageVisibility;
 export let pageVisibility;
 
 if (loadTimeData.getBoolean('isGuest')) {
+  const isEphemeralGuestProfile =
+      loadTimeData.getBoolean('isEphemeralGuestProfile');
+
   // "if not chromeos" and "if chromeos" in two completely separate blocks
   // to work around closure compiler.
   // <if expr="not chromeos">
   pageVisibility = {
-    autofill: false,
-    people: false,
+    autofill: isEphemeralGuestProfile,
+    people: isEphemeralGuestProfile,
     privacy: false,
     onStartup: false,
     reset: false,

chrome/browser/resources/settings/route.js

@@ -102,7 +102,8 @@ function createBrowserSettingsRoutes() {
   r.SIGN_OUT.isNavigableDialog = true;
 
   r.SEARCH = r.BASIC.createSection('/search', 'search');
-  if (!loadTimeData.getBoolean('isGuest')) {
+  if (!loadTimeData.getBoolean('isGuest') ||
+      loadTimeData.getBoolean('isEphemeralGuestProfile')) {
     r.PEOPLE = r.BASIC.createSection('/people', 'people');
     r.SYNC = r.PEOPLE.createChild('/syncSetup');
     r.SYNC_ADVANCED = r.SYNC.createChild('/syncSetup/advanced');

chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc

@@ -190,7 +190,7 @@ void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {
       user_manager::UserManager::Get()->IsLoggedInAsGuest() ||
           user_manager::UserManager::Get()->IsLoggedInAsPublicAccount());
 #else
-      profile->IsOffTheRecord());
+      profile->IsGuestSession() || profile->IsEphemeralGuestProfile());
 #endif
 
   html_source->AddBoolean("isSupervised", profile->IsSupervised());

chrome/browser/ui/webui/settings/settings_ui.cc

@@ -281,6 +281,9 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
       "enableContentSettingsRedesign",
       base::FeatureList::IsEnabled(features::kContentSettingsRedesign));
 
+  html_source->AddBoolean("isEphemeralGuestProfile",
+                          profile->IsEphemeralGuestProfile());
+
 #if defined(OS_WIN)
   html_source->AddBoolean(
       "safetyCheckChromeCleanerChildEnabled",