Commit f37464e6 authored by Richard He's avatar Richard He Committed by Commit Bot

Android: fix dummy FeedNewTabPage build break

Fix build break when `enable_feed_in_chrome = false`.

Change-Id: I7a3dbb52b47a6cf9ef7081b022ae15db61c26e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154628Reviewed-by: default avatarDan H <harringtond@chromium.org>
Commit-Queue: Richard He <linyhe@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#760291}
parent 34a10c6e
...@@ -51,7 +51,7 @@ public class FeedNewTabPage ...@@ -51,7 +51,7 @@ public class FeedNewTabPage
* @param fullscreenManager {@link ChromeFullscreenManager} to observe for offset changes. * @param fullscreenManager {@link ChromeFullscreenManager} to observe for offset changes.
* @param activityTabProvider Provides the current active tab. * @param activityTabProvider Provides the current active tab.
* @param overviewModeBehavior Overview mode to observe for mode changes. * @param overviewModeBehavior Overview mode to observe for mode changes.
* @param snackbarManager {@link SnackBarManager} object. * @param snackbarManager {@link SnackbarManager} object.
* @param lifecycleDispatcher Activity lifecycle dispatcher. * @param lifecycleDispatcher Activity lifecycle dispatcher.
* @param tabModelSelector {@link TabModelSelector} object. * @param tabModelSelector {@link TabModelSelector} object.
* @param isTablet {@code true} if running on a Tablet device. * @param isTablet {@code true} if running on a Tablet device.
......
...@@ -4,14 +4,20 @@ ...@@ -4,14 +4,20 @@
package org.chromium.chrome.browser.feed; package org.chromium.chrome.browser.feed;
import android.app.Activity;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import org.chromium.chrome.browser.ActivityTabProvider; import org.chromium.base.supplier.Supplier;
import org.chromium.chrome.browser.ChromeActivity; import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher; import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
import org.chromium.chrome.browser.ntp.NewTabPage; import org.chromium.chrome.browser.ntp.NewTabPage;
import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelSelector; import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.ui.messages.snackbar.SnackbarManager;
import org.chromium.chrome.browser.ui.native_page.NativePageHost; import org.chromium.chrome.browser.ui.native_page.NativePageHost;
/** /**
...@@ -21,18 +27,27 @@ public class FeedNewTabPage extends NewTabPage { ...@@ -21,18 +27,27 @@ public class FeedNewTabPage extends NewTabPage {
/** /**
* Constructs a new {@link FeedNewTabPage}. * Constructs a new {@link FeedNewTabPage}.
* *
* @param activity The containing {@link ChromeActivity}. * @param activity The containing {@link Activity}.
* @param fullscreenManager {@link ChromeFullscreenManager} to observe for offset changes.
* @param activityTabProvider Provides the current active tab.
* @param overviewModeBehavior Overview mode to observe for mode changes.
* @param snackbarManager {@link SnackbarManager} object.
* @param lifecycleDispatcher Activity lifecycle dispatcher.
* @param tabModelSelector {@link TabModelSelector} object.
* @param isTablet {@code true} if running on a Tablet device.
* @param uma {@link NewTabPageUma} object recording user metrics.
* @param isInNightMode {@code true} if the night mode setting is on.
* @param nativePageHost The host for this native page. * @param nativePageHost The host for this native page.
* @param tabModelSelector The {@link TabModelSelector} for the containing activity.
* @param activityTabProvider Allows us to check if we are the current tab.
* @param activityLifecycleDispatcher Allows us to subscribe to backgrounding events.
* @param tab The {@link Tab} that contains this new tab page. * @param tab The {@link Tab} that contains this new tab page.
*/ */
public FeedNewTabPage(ChromeActivity activity, NativePageHost nativePageHost, public FeedNewTabPage(Activity activity, ChromeFullscreenManager fullscreenManager,
TabModelSelector tabModelSelector, ActivityTabProvider activityTabProvider, Supplier<Tab> activityTabProvider, @Nullable OverviewModeBehavior overviewModeBehavior,
ActivityLifecycleDispatcher activityLifecycleDispatcher, Tab tab) { SnackbarManager snackbarManager, ActivityLifecycleDispatcher lifecycleDispatcher,
super(activity, nativePageHost, tabModelSelector, activityTabProvider, TabModelSelector tabModelSelector, boolean isTablet, NewTabPageUma uma,
activityLifecycleDispatcher, tab); boolean isInNightMode, NativePageHost nativePageHost, Tab tab) {
super(activity, fullscreenManager, activityTabProvider, overviewModeBehavior,
snackbarManager, lifecycleDispatcher, tabModelSelector, isTablet, uma,
isInNightMode, nativePageHost, tab);
} }
@VisibleForTesting @VisibleForTesting
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment