Commit f37588ad authored by Eugene But's avatar Eugene But Committed by Commit Bot

[ios] Fix getPasswordForms method signature

Update method and argument names to follow Coding Style for Cocoa:
 - make word before the argument describe the argument
 - use all caps for acronym in the argument name

Bug: None
Change-Id: Ice41e237985eb1ad0251c4ec96ebd970f9639c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524040Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826807}
parent 97cbd08c
...@@ -63,9 +63,9 @@ constexpr char kCommandPrefix[] = "passwordForm"; ...@@ -63,9 +63,9 @@ constexpr char kCommandPrefix[] = "passwordForm";
// Parses the |jsonString| which contatins the password forms found on a web // Parses the |jsonString| which contatins the password forms found on a web
// page to populate the |forms| vector. // page to populate the |forms| vector.
- (void)getPasswordFormsFromJSON:(NSString*)jsonString - (void)getPasswordForms:(std::vector<FormData>*)forms
pageURL:(const GURL&)pageURL fromJSON:(NSString*)jsonString
forms:(std::vector<FormData>*)forms; pageURL:(const GURL&)pageURL;
@end @end
...@@ -228,11 +228,11 @@ constexpr char kCommandPrefix[] = "passwordForm"; ...@@ -228,11 +228,11 @@ constexpr char kCommandPrefix[] = "passwordForm";
return NO; return NO;
} }
- (void)getPasswordFormsFromJSON:(NSString*)jsonString - (void)getPasswordForms:(std::vector<FormData>*)forms
pageURL:(const GURL&)pageURL fromJSON:(NSString*)JSONString
forms:(std::vector<FormData>*)forms { pageURL:(const GURL&)pageURL {
std::vector<FormData> formsData; std::vector<FormData> formsData;
if (!autofill::ExtractFormsData(jsonString, false, base::string16(), pageURL, if (!autofill::ExtractFormsData(JSONString, false, base::string16(), pageURL,
pageURL.GetOrigin(), &formsData)) { pageURL.GetOrigin(), &formsData)) {
return; return;
} }
...@@ -276,11 +276,11 @@ constexpr char kCommandPrefix[] = "passwordForm"; ...@@ -276,11 +276,11 @@ constexpr char kCommandPrefix[] = "passwordForm";
__weak PasswordFormHelper* weakSelf = self; __weak PasswordFormHelper* weakSelf = self;
[self.jsPasswordManager [self.jsPasswordManager
findPasswordFormsInFrame:GetMainFrame(_webState) findPasswordFormsInFrame:GetMainFrame(_webState)
completionHandler:^(NSString* jsonString) { completionHandler:^(NSString* JSONString) {
std::vector<FormData> forms; std::vector<FormData> forms;
[weakSelf getPasswordFormsFromJSON:jsonString [weakSelf getPasswordForms:&forms
pageURL:pageURL fromJSON:JSONString
forms:&forms]; pageURL:pageURL];
// Find the maximum extracted value. // Find the maximum extracted value.
uint32_t maxID = 0; uint32_t maxID = 0;
for (const auto& form : forms) { for (const auto& form : forms) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment