Commit f3767c02 authored by Julie Jeongeun Kim's avatar Julie Jeongeun Kim Committed by Commit Bot

Change FrameMsg_ChildFrameProcessGone to mojom

This CL converts FrameMsg_ChildFrameProcessGone to RenderFrameProxy
and removes FrameMsg_ChildFrameProcessGone message.

Bug: 1051137
Change-Id: I55e24ee59d2c15273988f7d1636edfe2f0198f4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062010Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#742536}
parent e3b22001
...@@ -146,8 +146,7 @@ void CrossProcessFrameConnector::RenderProcessGone() { ...@@ -146,8 +146,7 @@ void CrossProcessFrameConnector::RenderProcessGone() {
if (IsVisible()) if (IsVisible())
MaybeLogCrash(CrashVisibility::kCrashedWhileVisible); MaybeLogCrash(CrashVisibility::kCrashedWhileVisible);
frame_proxy_in_parent_renderer_->Send(new FrameMsg_ChildFrameProcessGone( frame_proxy_in_parent_renderer_->ChildProcessGone();
frame_proxy_in_parent_renderer_->GetRoutingID()));
auto* parent_view = GetParentRenderWidgetHostView(); auto* parent_view = GetParentRenderWidgetHostView();
if (parent_view && parent_view->host()->delegate()) if (parent_view && parent_view->host()->delegate())
......
...@@ -462,6 +462,10 @@ void RenderFrameProxyHost::DidUpdateVisualProperties( ...@@ -462,6 +462,10 @@ void RenderFrameProxyHost::DidUpdateVisualProperties(
GetAssociatedRenderFrameProxy()->DidUpdateVisualProperties(metadata); GetAssociatedRenderFrameProxy()->DidUpdateVisualProperties(metadata);
} }
void RenderFrameProxyHost::ChildProcessGone() {
GetAssociatedRenderFrameProxy()->ChildProcessGone();
}
void RenderFrameProxyHost::OnRouteMessageEvent( void RenderFrameProxyHost::OnRouteMessageEvent(
const FrameMsg_PostMessage_Params& params) { const FrameMsg_PostMessage_Params& params) {
RenderFrameHostImpl* target_rfh = frame_tree_node()->current_frame_host(); RenderFrameHostImpl* target_rfh = frame_tree_node()->current_frame_host();
......
...@@ -168,8 +168,8 @@ class CONTENT_EXPORT RenderFrameProxyHost ...@@ -168,8 +168,8 @@ class CONTENT_EXPORT RenderFrameProxyHost
// Requests a viz::LocalSurfaceId to disable auto-resize mode from the parent // Requests a viz::LocalSurfaceId to disable auto-resize mode from the parent
// renderer. // renderer.
void DisableAutoResize(); void DisableAutoResize();
void DidUpdateVisualProperties(const cc::RenderFrameMetadata& metadata); void DidUpdateVisualProperties(const cc::RenderFrameMetadata& metadata);
void ChildProcessGone();
blink::AssociatedInterfaceProvider* GetRemoteAssociatedInterfacesTesting(); blink::AssociatedInterfaceProvider* GetRemoteAssociatedInterfacesTesting();
bool IsInertForTesting(); bool IsInertForTesting();
......
...@@ -523,10 +523,6 @@ IPC_STRUCT_TRAITS_END() ...@@ -523,10 +523,6 @@ IPC_STRUCT_TRAITS_END()
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
// Messages sent from the browser to the renderer. // Messages sent from the browser to the renderer.
// Notifies the embedding frame that the process rendering the child frame's
// contents has terminated.
IPC_MESSAGE_ROUTED0(FrameMsg_ChildFrameProcessGone)
// Sent in response to a FrameHostMsg_ContextMenu to let the renderer know that // Sent in response to a FrameHostMsg_ContextMenu to let the renderer know that
// the menu has been closed. // the menu has been closed.
IPC_MESSAGE_ROUTED1(FrameMsg_ContextMenuClosed, IPC_MESSAGE_ROUTED1(FrameMsg_ContextMenuClosed,
......
...@@ -19,6 +19,10 @@ interface RenderFrameProxyHost { ...@@ -19,6 +19,10 @@ interface RenderFrameProxyHost {
// RenderFrameProxy. Implemented by renderer processes, called by the browser // RenderFrameProxy. Implemented by renderer processes, called by the browser
// process. // process.
interface RenderFrameProxy { interface RenderFrameProxy {
// Notifies the remote frame that the process rendering the child frame's
// contents has terminated.
ChildProcessGone();
// This function enables auto-resize mode from the parent renderer. // This function enables auto-resize mode from the parent renderer.
EnableAutoResize(gfx.mojom.Size min_size, gfx.mojom.Size max_size); EnableAutoResize(gfx.mojom.Size min_size, gfx.mojom.Size max_size);
......
...@@ -374,7 +374,6 @@ bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) { ...@@ -374,7 +374,6 @@ bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) {
bool handled = true; bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderFrameProxy, msg) IPC_BEGIN_MESSAGE_MAP(RenderFrameProxy, msg)
IPC_MESSAGE_HANDLER(FrameMsg_ChildFrameProcessGone, OnChildFrameProcessGone)
IPC_MESSAGE_HANDLER(FrameMsg_UpdateOpener, OnUpdateOpener) IPC_MESSAGE_HANDLER(FrameMsg_UpdateOpener, OnUpdateOpener)
IPC_MESSAGE_HANDLER(FrameMsg_ViewChanged, OnViewChanged) IPC_MESSAGE_HANDLER(FrameMsg_ViewChanged, OnViewChanged)
IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateName, OnDidUpdateName) IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateName, OnDidUpdateName)
...@@ -413,7 +412,7 @@ void RenderFrameProxy::OnDeleteProxy() { ...@@ -413,7 +412,7 @@ void RenderFrameProxy::OnDeleteProxy() {
web_frame_->Detach(); web_frame_->Detach();
} }
void RenderFrameProxy::OnChildFrameProcessGone() { void RenderFrameProxy::ChildProcessGone() {
crashed_ = true; crashed_ = true;
compositing_helper_->ChildFrameGone(local_frame_size(), compositing_helper_->ChildFrameGone(local_frame_size(),
screen_info().device_scale_factor); screen_info().device_scale_factor);
......
...@@ -221,7 +221,6 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener, ...@@ -221,7 +221,6 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener,
// IPC handlers // IPC handlers
void OnDeleteProxy(); void OnDeleteProxy();
void OnChildFrameProcessGone();
void OnCompositorFrameSwapped(const IPC::Message& message); void OnCompositorFrameSwapped(const IPC::Message& message);
void OnUpdateOpener(int opener_routing_id); void OnUpdateOpener(int opener_routing_id);
void OnViewChanged(const FrameMsg_ViewChanged_Params& params); void OnViewChanged(const FrameMsg_ViewChanged_Params& params);
...@@ -236,6 +235,7 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener, ...@@ -236,6 +235,7 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener,
void DisableAutoResize() override; void DisableAutoResize() override;
void DidUpdateVisualProperties( void DidUpdateVisualProperties(
const cc::RenderFrameMetadata& metadata) override; const cc::RenderFrameMetadata& metadata) override;
void ChildProcessGone() override;
// ChildFrameCompositor: // ChildFrameCompositor:
cc::Layer* GetLayer() override; cc::Layer* GetLayer() override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment