Commit f37c26a0 authored by Jose Dapena Paz's avatar Jose Dapena Paz Committed by Commit Bot

cc: fix pure virtual crash in TileManagerCheckRasterQueriesTest

RasterBufferProvider instance set by test was used after it was
destroyed. Fix is doing same as in the other tests in TileManager
unit tests: cleanup the reference before with TakeHostImpl() call.

Change-Id: Iaadf91d80686093cd3fc69a40cbfd22f3d45e9d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554668
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648334}
parent 5ca96176
...@@ -3429,6 +3429,10 @@ TEST_F(DecodedImageTrackerTileManagerTest, DecodedImageTrackerDropsLocksOnUse) { ...@@ -3429,6 +3429,10 @@ TEST_F(DecodedImageTrackerTileManagerTest, DecodedImageTrackerDropsLocksOnUse) {
class TileManagerCheckRasterQueriesTest : public TileManagerTest { class TileManagerCheckRasterQueriesTest : public TileManagerTest {
public: public:
~TileManagerCheckRasterQueriesTest() override {
// Ensure that the host impl doesn't outlive |raster_buffer_provider_|.
TakeHostImpl();
}
void SetUp() override { void SetUp() override {
TileManagerTest::SetUp(); TileManagerTest::SetUp();
host_impl()->tile_manager()->SetRasterBufferProviderForTesting( host_impl()->tile_manager()->SetRasterBufferProviderForTesting(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment