Commit f3d0fb8d authored by Jonah Ryan-Davis's avatar Jonah Ryan-Davis Committed by Commit Bot

Use validating cmd decoder on WebGL/pixel tests

Because of a finch trial of DefaultPassthroughCommandDecoder, a few bots
which were relying on the default to test the validating command decoder
ended up switching to passthrough. This CL reconfigures to be more
explicit

TBR=kbr@chromium.org

Bug: 1014368
Bug: 1014370
Change-Id: I5ca6c380755d529ce506e86ececbf070f472bd33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863152
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: default avatarKai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706087}
parent b4b8a01e
......@@ -571,7 +571,7 @@
"--browser=cros-chrome",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--remote=127.0.0.1",
"--remote-ssh-port=9222"
],
......
......@@ -8137,7 +8137,7 @@
"--browser=cros-chrome",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--remote=variable_chromeos_device_hostname"
],
"isolate_name": "telemetry_gpu_integration_test",
......
This diff is collapsed.
......@@ -313,7 +313,7 @@
"--browser=android-chromium",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl_conformance_tests_output.json"
],
"isolate_name": "telemetry_gpu_integration_test",
......@@ -747,7 +747,7 @@
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -1175,7 +1175,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -1559,7 +1559,7 @@
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -1966,7 +1966,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -2373,7 +2373,7 @@
"--browser=debug",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -2808,7 +2808,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -3305,7 +3305,7 @@
"--browser=debug_x64",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -3945,7 +3945,7 @@
"--browser=release_x64",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......
......@@ -302,7 +302,7 @@
"--browser=android-chromium",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl_conformance_tests_output.json"
],
"isolate_name": "telemetry_gpu_integration_test",
......@@ -590,7 +590,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--webgl-conformance-version=2.0.1",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl2_conformance_tests_output.json"
],
......@@ -621,7 +621,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -907,7 +907,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--webgl-conformance-version=2.0.1",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl2_conformance_tests_output.json"
],
......@@ -938,7 +938,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -1216,7 +1216,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--webgl-conformance-version=2.0.1",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl2_conformance_tests_output.json"
],
......@@ -1246,7 +1246,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......@@ -1857,7 +1857,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating",
"--webgl-conformance-version=2.0.1",
"--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl2_conformance_tests_output.json"
],
......@@ -1888,7 +1888,7 @@
"--browser=release",
"--passthrough",
"-v",
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu"
"--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --force_high_performance_gpu --use-cmd-decoder=validating"
],
"isolate_name": "telemetry_gpu_integration_test",
"merge": {
......
......@@ -3877,7 +3877,7 @@
'${got_revision}',
'--test-machine-name',
'${buildername}',
'--extra-browser-args=--use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer',
'--extra-browser-args=--use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer --use-cmd-decoder=validating',
],
'precommit_args': [
# Gerrit issue ID
......@@ -4015,7 +4015,7 @@
# it.
'--read-abbreviated-json-results-from=../../content/test/data/gpu/webgl2_conformance_tests_output.json',
# On dual-GPU devices we want the high-performance GPU to be active
'--extra-browser-args=--force_high_performance_gpu',
'--extra-browser-args=--force_high_performance_gpu --use-cmd-decoder=validating',
],
'swarming': {
# These tests currently take about an hour and fifteen minutes
......@@ -4088,7 +4088,7 @@
],
'args': [
# On dual-GPU devices we want the high-performance GPU to be active
'--extra-browser-args=--force_high_performance_gpu',
'--extra-browser-args=--force_high_performance_gpu --use-cmd-decoder=validating',
],
'swarming': {
'shards': 2,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment