Commit f3e8d758 authored by Travis Skare's avatar Travis Skare Committed by Commit Bot

Update TODO comment around regular vs incognito profiles.

No functional changes.

Added some if-change-then-change in another location.

Change-Id: I4a116bb506f5f8830905381e3b687b9d6ed13456
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108637Reviewed-by: default avatarJeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: default avatarTanya Gupta <tgupta@chromium.org>
Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751457}
parent aab47f16
......@@ -63,9 +63,9 @@ public class NotificationManager {
final String action = intent.getAction();
final String guid =
IntentUtils.safeGetStringExtra(intent, NOTIFICATION_GUID_EXTRA);
// TODO(https://crbug.com/1041781): Use the current profile (i.e.,
// regular profile or incognito profile) instead of always using
// regular profile. It is wrong and need to be fixed.
// If this feature ever supports incognito mode, we need to modify
// this method to obtain the current profile, rather than the last-used
// regular profile.
final Profile profile = Profile.getLastUsedRegularProfile();
switch (action) {
case NOTIFICATION_ACTION_TAP:
......
......@@ -97,6 +97,9 @@ TEST_F(SendTabToSelfUtilTest, NativePage) {
}
TEST_F(SendTabToSelfUtilTest, IncognitoMode) {
// Note: if changing this, audit profile-finding logic in the feature.
// For example, NotificationManager.java in the Android code assumes
// incognito is not supported.
EXPECT_FALSE(AreContentRequirementsMet(url_, incognito_profile_));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment