Commit f3fc7c63 authored by Dominic Farolino's avatar Dominic Farolino Committed by Commit Bot

[inspector] Enable console tests and remove old expectations

The V8 CL (crrev.com/c/1902968) fixing console's table and dir method
lengths has been rolled into Chromium, so this CL re-enables the tests
and removes the IDL expectations now that the tests pass.

Bug: 948678
Change-Id: I9fd1719fdc7382747c017876740df5e15c81b18e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904335
Commit-Queue: Dominic Farolino <dom@chromium.org>
Reviewed-by: default avatarMathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714135}
parent 2e607ccb
...@@ -5896,8 +5896,4 @@ crbug.com/963183 http/tests/devtools/sources/debugger/debugger-proto-property.js ...@@ -5896,8 +5896,4 @@ crbug.com/963183 http/tests/devtools/sources/debugger/debugger-proto-property.js
# Temporarily disabled to land scope changes in DevTools # Temporarily disabled to land scope changes in DevTools
crbug.com/963183 http/tests/devtools/sources/debugger-pause/set-return-value.js [ Pass Failure ] crbug.com/963183 http/tests/devtools/sources/debugger-pause/set-return-value.js [ Pass Failure ]
# Adjusting v8 console implementation, pass failure until v8 change lands
crbug.com/948678 external/wpt/console/idlharness.any.html [ Pass Failure ]
crbug.com/948678 external/wpt/console/idlharness.any.worker.html [ Pass Failure ]
crbug.com/892983 external/wpt/css/css-pseudo/first-line-with-before-after.html [ Failure ] crbug.com/892983 external/wpt/css/css-pseudo/first-line-with-before-after.html [ Failure ]
This is a testharness.js-based test.
PASS idl_test setup
PASS idl_test validation
PASS console namespace: operation assert(boolean, any...)
PASS console namespace: operation clear()
PASS console namespace: operation debug(any...)
PASS console namespace: operation error(any...)
PASS console namespace: operation info(any...)
PASS console namespace: operation log(any...)
FAIL console namespace: operation table(any, [object Object]) assert_equals: operation has wrong .length expected 0 but got 1
PASS console namespace: operation trace(any...)
PASS console namespace: operation warn(any...)
FAIL console namespace: operation dir(any, object) assert_equals: operation has wrong .length expected 0 but got 1
PASS console namespace: operation dirxml(any...)
PASS console namespace: operation count(DOMString)
PASS console namespace: operation countReset(DOMString)
PASS console namespace: operation group(any...)
PASS console namespace: operation groupCollapsed(any...)
PASS console namespace: operation groupEnd()
PASS console namespace: operation time(DOMString)
PASS console namespace: operation timeLog(DOMString, any...)
PASS console namespace: operation timeEnd(DOMString)
Harness: the test ran to completion.
This is a testharness.js-based test.
PASS idl_test setup
PASS idl_test validation
PASS console namespace: operation assert(boolean, any...)
PASS console namespace: operation clear()
PASS console namespace: operation debug(any...)
PASS console namespace: operation error(any...)
PASS console namespace: operation info(any...)
PASS console namespace: operation log(any...)
FAIL console namespace: operation table(any, [object Object]) assert_equals: operation has wrong .length expected 0 but got 1
PASS console namespace: operation trace(any...)
PASS console namespace: operation warn(any...)
FAIL console namespace: operation dir(any, object) assert_equals: operation has wrong .length expected 0 but got 1
PASS console namespace: operation dirxml(any...)
PASS console namespace: operation count(DOMString)
PASS console namespace: operation countReset(DOMString)
PASS console namespace: operation group(any...)
PASS console namespace: operation groupCollapsed(any...)
PASS console namespace: operation groupEnd()
PASS console namespace: operation time(DOMString)
PASS console namespace: operation timeLog(DOMString, any...)
PASS console namespace: operation timeEnd(DOMString)
Harness: the test ran to completion.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment