Add Passwords Weakness Check feature flag

This feature flag allows as to enable checking passwords for weakness
in chrome://settings/passwords/check.

Bug: 1119752
Change-Id: I24984ee3cd64778260195b4319262c8b7851895d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367033
Commit-Queue: Irina Fedorova <irfedorova@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800539}

chrome/browser/about_flags.cc

@@ -6344,6 +6344,12 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(blink::features::kAVIF)},
 #endif  // BUILDFLAG(ENABLE_AV1_DECODER)
 
+#if !defined(OS_ANDROID)
+    {"passwords-weakness-check", flag_descriptions::kPasswordsWeaknessCheckName,
+     flag_descriptions::kPasswordsWeaknessCheckDescription, kOsDesktop,
+     FEATURE_VALUE_TYPE(password_manager::features::kPasswordsWeaknessCheck)},
+#endif  // !defined(OS_ANDROID)
+
     // NOTE: Adding a new flag requires adding a corresponding entry to enum
     // "LoginCustomFlags" in tools/metrics/histograms/enums.xml. See "Flag
     // Histograms" in tools/metrics/histograms/README.md (run the

chrome/browser/flag-metadata.json

@@ -3611,6 +3611,11 @@
     "owners": [ "mamir", "treib" ],
     "expiry_milestone": 89
   },
+  {
+    "name": "passwords-weakness-check",
+    "owners": [ "irfedorova", "jdoerrie" ],
+    "expiry_milestone": 89
+  },
   {
     "name": "pdf-form-save",
     "owners": [ "thestig" ],

chrome/browser/flag_descriptions.cc

@@ -3358,6 +3358,10 @@ const char kOmniboxShortBookmarkSuggestionsDescription[] =
     "Match very short input words to beginning of words in bookmark "
     "suggestions.";
 
+const char kPasswordsWeaknessCheckName[] = "Passwords weakness check";
+const char kPasswordsWeaknessCheckDescription[] =
+    "Enables checking passwords for weakness in Password Check";
+
 const char kTabFreezeName[] = "Tab Freeze";
 const char kTabFreezeDescription[] =
     "Enables freezing eligible tabs when they have been backgrounded for 5 "

chrome/browser/flag_descriptions.h

@@ -1924,6 +1924,9 @@ extern const char kOmniboxKeywordSearchButtonDescription[];
 extern const char kOmniboxReverseAnswersName[];
 extern const char kOmniboxReverseAnswersDescription[];
 
+extern const char kPasswordsWeaknessCheckName[];
+extern const char kPasswordsWeaknessCheckDescription[];
+
 extern const char kTabFreezeName[];
 extern const char kTabFreezeDescription[];
 

chrome/browser/ui/webui/settings/settings_ui.cc

@@ -271,6 +271,11 @@ SettingsUI::SettingsUI(content::WebUI* web_ui)
       "enablePasswordCheck",
       base::FeatureList::IsEnabled(password_manager::features::kPasswordCheck));
 
+  html_source->AddBoolean(
+      "passwordsWeaknessCheck",
+      base::FeatureList::IsEnabled(
+          password_manager::features::kPasswordsWeaknessCheck));
+
   html_source->AddBoolean(
       "editPasswordsInSettings",
       base::FeatureList::IsEnabled(

components/password_manager/core/common/password_manager_features.cc

@@ -91,6 +91,10 @@ const base::Feature kPasswordImport = {"PasswordImport",
 const base::Feature kPasswordManagerOnboardingAndroid = {
     "PasswordManagerOnboardingAndroid", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Enables checking credentials for weakness in Password Check.
+const base::Feature kPasswordsWeaknessCheck = {
+    "PasswordsWeaknessCheck", base::FEATURE_DISABLED_BY_DEFAULT};
+
 // Enables showing UI which allows users to easily revert their choice to
 // never save passwords on a certain website.
 const base::Feature kRecoverFromNeverSaveAndroid = {

components/password_manager/core/common/password_manager_features.h

@@ -33,6 +33,7 @@ extern const base::Feature kPasswordCheck;
 extern const base::Feature kPasswordEditingAndroid;
 extern const base::Feature kPasswordImport;
 extern const base::Feature kPasswordManagerOnboardingAndroid;
+extern const base::Feature kPasswordsWeaknessCheck;
 extern const base::Feature kRecoverFromNeverSaveAndroid;
 extern const base::Feature kUsernameFirstFlow;
 extern const base::Feature kWellKnownChangePassword;

tools/metrics/histograms/enums.xml

@@ -41646,6 +41646,7 @@ from previous Chrome versions.
   <int value="-612633819" label="NotificationScrollBar:disabled"/>
   <int value="-612480090" label="FasterLocationReload:enabled"/>
   <int value="-610411643" label="enable-printer-app-search"/>
+  <int value="-608775184" label="PasswordsWeaknessCheck:enabled"/>
   <int value="-606898702" label="MaterialDesignSettings:disabled"/>
   <int value="-606696801" label="TabGroupsUiImprovementsAndroid:enabled"/>
   <int value="-606431158" label="DrawVerticallyEdgeToEdge:enabled"/>
@@ -42677,6 +42678,7 @@ from previous Chrome versions.
   <int value="502551931" label="IncognitoStrings:enabled"/>
   <int value="503189154" label="ViewsBrowserWindows:disabled"/>
   <int value="503245473" label="disable-translate-new-ux"/>
+  <int value="504717928" label="PasswordsWeaknessCheck:disabled"/>
   <int value="504994663" label="GenericSensor:disabled"/>
   <int value="505561325" label="OpenXR:disabled"/>
   <int value="506680761" label="WebNFC:disabled"/>