Commit f42884dd authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

macviews: disable a handful of AppWindowAPITests

These tests don't work in Views mode.

TBR=tapted@chromium.org

Bug: 834908
Change-Id: I5c0fdb9043511264d8d6e4b096a66be80eeaf8bd
Reviewed-on: https://chromium-review.googlesource.com/1020082Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552142}
parent 4a7c9fb7
......@@ -21,6 +21,7 @@
#if defined(OS_MACOSX)
#include "base/mac/mac_util.h"
#include "chrome/browser/ui/views_mode_controller.h"
#endif
using extensions::AppWindowGeometryCache;
......@@ -163,6 +164,8 @@ IN_PROC_BROWSER_TEST_F(AppWindowAPITest, MAYBE_TestMinimize) {
#if defined(OS_MACOSX)
if (base::mac::IsOS10_10())
return; // Fails when swarmed. http://crbug.com/660582
if (!views_mode_controller::IsViewsBrowserCocoa())
return; // Fails in Views mode: https://crbug.com/834908
#endif
ASSERT_TRUE(RunAppWindowAPITest("testMinimize")) << message_;
}
......@@ -196,10 +199,18 @@ IN_PROC_BROWSER_TEST_F(AppWindowAPITest, MAYBE_TestDeprecatedBounds) {
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, MAYBE_TestInitialBounds) {
#if defined(OS_MACOSX)
if (!views_mode_controller::IsViewsBrowserCocoa())
return; // Fails in Views mode: https://crbug.com/834908
#endif
ASSERT_TRUE(RunAppWindowAPITest("testInitialBounds")) << message_;
}
IN_PROC_BROWSER_TEST_F(AppWindowAPITest, MAYBE_TestInitialConstraints) {
#if defined(OS_MACOSX)
if (!views_mode_controller::IsViewsBrowserCocoa())
return; // Fails in Views mode: https://crbug.com/834908
#endif
ASSERT_TRUE(RunAppWindowAPITest("testInitialConstraints")) << message_;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment