Skip to content

GitLab

T
tangled
Commit f45b8394 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot
Browse files
Options

Closure compile device_hander_unittest 

 - remove device_handler_unittest.html
 - add BUILD rule to auto-generate this unit test
 - add BUILD rule to Closure compile this unit test
 - rename handler -> deviceHander, use mockChrome
   everywhere and also install it during Setup()
 - remove unused timeoutCallbacks var
 - fix Closure errors, js code auto-format

No change in test behavior, no new tests.

Bug: 908673
No-try: true
Change-Id: I46535df1c77a57c488e40f9c410ca4a62ad73ac5
Reviewed-on: https://chromium-review.googlesource.com/c/1351336
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611000}
parent 620e9b73
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 215 additions and 264 deletions
chrome/browser/chromeos/file_manager/file_manager_jstest.cc
View file @ f45b8394
...@@ -35,8 +35,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ProgressCenterItemGroupTest) { ...@@ -35,8 +35,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ProgressCenterItemGroupTest) {
} }
IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DeviceHandlerTest) { IN_PROC_BROWSER_TEST_F(FileManagerJsTest, DeviceHandlerTest) {
RunTest(base::FilePath( RunGeneratedTest("/background/js/device_handler_unittest.html");
FILE_PATH_LITERAL("background/js/device_handler_unittest.html")));
} }
IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileOperationManagerTest) { IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileOperationManagerTest) {
......
ui/file_manager/file_manager/background/js/BUILD.gn
View file @ f45b8394
...@@ -167,6 +167,16 @@ js_library("device_handler") { ...@@ -167,6 +167,16 @@ js_library("device_handler") {
] ]
} }
js_unittest("device_handler_unittest") {
deps = [
":device_handler",
":mock_volume_manager",
"//ui/file_manager/base/js:mock_chrome",
"//ui/file_manager/base/js:test_error_reporting",
"//ui/file_manager/file_manager/common/js:test_importer_common",
]
}
js_library("mock_drive_sync_handler") { js_library("mock_drive_sync_handler") {
testonly = true testonly = true
deps = [ deps = [
...@@ -451,6 +461,7 @@ js_library("volume_manager_util") { ...@@ -451,6 +461,7 @@ js_library("volume_manager_util") {
js_unit_tests("unit_tests") { js_unit_tests("unit_tests") {
deps = [ deps = [
":crostini_unittest", ":crostini_unittest",
":device_handler_unittest",
":duplicate_finder_unittest", ":duplicate_finder_unittest",
":import_history_unittest", ":import_history_unittest",
":media_scanner_unittest", ":media_scanner_unittest",
......
ui/file_manager/file_manager/background/js/device_handler_unittest.html deleted 100644 → 0
View file @ 620e9b73
<!DOCTYPE html>
<!-- Copyright 2014 The Chromium Authors. All rights reserved.
-- Use of this source code is governed by a BSD-style license that can be
-- found in the LICENSE file.
-->
<html>
<body>
<script src="../../../../../ui/webui/resources/js/assert.js"></script>
<script src="../../../../../ui/webui/resources/js/cr.js"></script>
<script src="../../../../../ui/webui/resources/js/cr/event_target.js"></script>
<script src="../../../../../ui/webui/resources/js/cr/ui/array_data_model.js"></script>
<script src="../../../../../ui/webui/resources/js/load_time_data.js"></script>
<!-- Need to load async_util.js before device_handler.js -->
<script src="../../common/js/async_util.js"></script>
<script src="../../../base/js/test_error_reporting.js"></script>
<script src="../../../base/js/mock_chrome.js"></script>
<script src="../../common/js/unittest_util.js"></script>
<script src="../../common/js/mock_entry.js"></script>
<script src="../../../base/js/volume_manager_types.js"></script>
<script src="../../common/js/importer_common.js"></script>
<script src="../../common/js/files_app_entry_types.js"></script>
<script src="../../common/js/util.js"></script>
<script src="device_handler.js"></script>
<script src="volume_info_impl.js"></script>
<script src="volume_info_list_impl.js"></script>
<script src="volume_manager_factory.js"></script>
<script src="volume_manager_impl.js"></script>
<script src="volume_manager_util.js"></script>
<script src="mock_volume_manager.js"></script>
<script src="device_handler_unittest.js"></script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment