[NTP] Add PRESUBMIT.py for local_ntp/

Add presubmit that checks for changes to local_ntp.html that don't also include changes to local_ntp_browsertest.html. Bug: None Change-Id: I5ab07a46800d4a9fdac2fd7978fe250a4a0bdf22 Reviewed-on: https://chromium-review.googlesource.com/c/1477769 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634344}

[NTP] Add PRESUBMIT.py for local_ntp/
Add presubmit that checks for changes to local_ntp.html that don't also include changes to local_ntp_browsertest.html. Bug: None Change-Id: I5ab07a46800d4a9fdac2fd7978fe250a4a0bdf22 Reviewed-on: https://chromium-review.googlesource.com/c/1477769 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634344}
f4751993 · Kyle Milka · Commit Bot · cc7fa1a2 · f4751993 · f4751993
Commit f4751993 authored Feb 21, 2019 by Kyle Milka Committed by Commit Bot Feb 21, 2019
Showing with 22 additions and 2 deletions

chrome/browser/resources/local_ntp/PRESUBMIT.py chrome/browser/resources/local_ntp/PRESUBMIT.py +22 -0

chrome/browser/resources/local_ntp/local_ntp.html chrome/browser/resources/local_ntp/local_ntp.html +0 -2

No files found.
--- a/chrome/browser/resources/local_ntp/PRESUBMIT.py
+++ b/chrome/browser/resources/local_ntp/PRESUBMIT.py
+# Copyright 2019 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+'Presubmit script for changes affecting chrome/browser/resources/local_ntp/'
+def NTPPresubmitChecks(input_api, output_api):
+  affected = input_api.change.AffectedFiles()
+  warning_str = ('Test HTML files in chrome/test/data/local_ntp/ should be '
+                 'updated when making changes to local_ntp.html');
+  if (any(f for f in affected if
+          f.LocalPath().endswith('local_ntp.html')) and
+      not any(f for f in affected if
+              f.LocalPath().endswith('local_ntp_browsertest.html'))):
+    return [output_api.PresubmitPromptWarning(warning_str)]
+  return []
+def CheckChangeOnUpload(input_api, output_api):
+  return NTPPresubmitChecks(input_api, output_api)
+def CheckChangeOnCommit(input_api, output_api):
+  return NTPPresubmitChecks(input_api, output_api)
--- a/chrome/browser/resources/local_ntp/local_ntp.html
+++ b/chrome/browser/resources/local_ntp/local_ntp.html
@@ -29,8 +29,6 @@
  <meta name="google" value="notranslate">
  <meta name="referrer" content="strict-origin">
 </head>
-<!-- Remember to update the test HTML files in chrome/test/data/local_ntp/
-     whenever making changes to this file.-->
 <body>
  <div id="custom-bg"></div>
  <!-- Container for the OneGoogleBar HTML. -->