Commit f4866444 authored by David Van Cleve's avatar David Van Cleve Committed by Commit Bot

Removes some post-refactor left over dead code

Following some earlier Onion Soup refactoring,
blink::PrivacyPreferences has no usage---only a couple scary
comments in renderer_preferences.mojom warning to keep fields "in sync"
with PrivacyPreferences.

This change deletes the dead PrivacyPreferences code and the scary
comments.

R=shimazu

Bug: 869748
Change-Id: If95f5da0fe40ec6507d34b8985b8c13f5685f3ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833707
Auto-Submit: David Van Cleve <davidvc@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#702038}
parent 40608b3c
...@@ -175,9 +175,6 @@ EmbeddedWorkerInstanceClientImpl::BuildStartData( ...@@ -175,9 +175,6 @@ EmbeddedWorkerInstanceClientImpl::BuildStartData(
? blink::WebEmbeddedWorkerStartData::kWaitForDebugger ? blink::WebEmbeddedWorkerStartData::kWaitForDebugger
: blink::WebEmbeddedWorkerStartData::kDontWaitForDebugger; : blink::WebEmbeddedWorkerStartData::kDontWaitForDebugger;
start_data->devtools_worker_token = params.devtools_worker_token; start_data->devtools_worker_token = params.devtools_worker_token;
start_data->privacy_preferences = blink::PrivacyPreferences(
params.renderer_preferences->enable_do_not_track,
params.renderer_preferences->enable_referrers);
return start_data; return start_data;
} }
......
...@@ -11,7 +11,6 @@ ...@@ -11,7 +11,6 @@
#include "content/common/content_export.h" #include "content/common/content_export.h"
#include "mojo/public/cpp/bindings/pending_receiver.h" #include "mojo/public/cpp/bindings/pending_receiver.h"
#include "mojo/public/cpp/bindings/receiver.h" #include "mojo/public/cpp/bindings/receiver.h"
#include "third_party/blink/public/common/privacy_preferences.h"
#include "third_party/blink/public/mojom/service_worker/embedded_worker.mojom.h" #include "third_party/blink/public/mojom/service_worker/embedded_worker.mojom.h"
#include "third_party/blink/public/mojom/service_worker/service_worker_installed_scripts_manager.mojom.h" #include "third_party/blink/public/mojom/service_worker/service_worker_installed_scripts_manager.mojom.h"
#include "third_party/blink/public/mojom/worker/worker_content_settings_proxy.mojom.h" #include "third_party/blink/public/mojom/worker/worker_content_settings_proxy.mojom.h"
......
...@@ -79,7 +79,6 @@ jumbo_source_set("common") { ...@@ -79,7 +79,6 @@ jumbo_source_set("common") {
"origin_trials/trial_token_validator.cc", "origin_trials/trial_token_validator.cc",
"page/page_zoom.cc", "page/page_zoom.cc",
"peerconnection/webrtc_ip_handling_policy.cc", "peerconnection/webrtc_ip_handling_policy.cc",
"privacy_preferences.cc",
"scheduler/web_scheduler_tracked_feature.cc", "scheduler/web_scheduler_tracked_feature.cc",
"service_worker/service_worker_status_code.cc", "service_worker/service_worker_status_code.cc",
"service_worker/service_worker_type_converters.cc", "service_worker/service_worker_type_converters.cc",
......
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "third_party/blink/public/common/privacy_preferences.h"
namespace blink {
PrivacyPreferences::PrivacyPreferences(bool enable_do_not_track,
bool enable_referrers)
: enable_do_not_track(enable_do_not_track),
enable_referrers(enable_referrers) {}
} // namespace blink
...@@ -115,7 +115,6 @@ source_set("headers") { ...@@ -115,7 +115,6 @@ source_set("headers") {
"page/page_zoom.h", "page/page_zoom.h",
"peerconnection/webrtc_ip_handling_policy.h", "peerconnection/webrtc_ip_handling_policy.h",
"prerender/prerender_rel_type.h", "prerender/prerender_rel_type.h",
"privacy_preferences.h",
"scheduler/web_scheduler_tracked_feature.h", "scheduler/web_scheduler_tracked_feature.h",
"screen_orientation/web_screen_orientation_lock_type.h", "screen_orientation/web_screen_orientation_lock_type.h",
"screen_orientation/web_screen_orientation_type.h", "screen_orientation/web_screen_orientation_type.h",
......
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef THIRD_PARTY_BLINK_PUBLIC_COMMON_PRIVACY_PREFERENCES_H_
#define THIRD_PARTY_BLINK_PUBLIC_COMMON_PRIVACY_PREFERENCES_H_
#include "third_party/blink/public/common/common_export.h"
namespace blink {
// Subset of content::RendererPreferences for passing the security info to
// blink.
// TODO(crbug.com/869748): Move this into a mojom struct and use the new struct
// as a part of RendererPreferences once RendererPreferences becomes a mojom
// struct.
struct BLINK_COMMON_EXPORT PrivacyPreferences {
PrivacyPreferences() = default;
PrivacyPreferences(bool enable_do_not_track,
bool enable_referrers);
// These default values are coming from the defaults in
// content::RendererPreferences.
bool enable_do_not_track = false;
bool enable_referrers = true;
};
} // namespace blink
#endif // THIRD_PARTY_BLINK_PUBLIC_COMMON_PRIVACY_PREFERENCES_H_
...@@ -63,7 +63,6 @@ struct RendererPreferences { ...@@ -63,7 +63,6 @@ struct RendererPreferences {
bool use_custom_colors = true; bool use_custom_colors = true;
// Set to false to not send referrers. // Set to false to not send referrers.
// The default value should be in sync with blink::PrivacyPreferences.
bool enable_referrers = true; bool enable_referrers = true;
// Set to true to allow third-party sub-content to pop-up HTTP basic auth // Set to true to allow third-party sub-content to pop-up HTTP basic auth
...@@ -71,7 +70,6 @@ struct RendererPreferences { ...@@ -71,7 +70,6 @@ struct RendererPreferences {
bool allow_cross_origin_auth_prompt = false; bool allow_cross_origin_auth_prompt = false;
// Set to true to indicate that the preference to set DNT to 1 is enabled. // Set to true to indicate that the preference to set DNT to 1 is enabled.
// The default value should be in sync with blink::PrivacyPreferences.
bool enable_do_not_track = false; bool enable_do_not_track = false;
// Whether to allow the use of Encrypted Media Extensions (EME), except for // Whether to allow the use of Encrypted Media Extensions (EME), except for
......
...@@ -33,7 +33,6 @@ ...@@ -33,7 +33,6 @@
#include "base/unguessable_token.h" #include "base/unguessable_token.h"
#include "services/network/public/mojom/ip_address_space.mojom-shared.h" #include "services/network/public/mojom/ip_address_space.mojom-shared.h"
#include "third_party/blink/public/common/privacy_preferences.h"
#include "third_party/blink/public/mojom/service_worker/service_worker_registration.mojom-shared.h" #include "third_party/blink/public/mojom/service_worker/service_worker_registration.mojom-shared.h"
#include "third_party/blink/public/platform/web_content_security_policy.h" #include "third_party/blink/public/platform/web_content_security_policy.h"
#include "third_party/blink/public/platform/web_string.h" #include "third_party/blink/public/platform/web_string.h"
...@@ -56,8 +55,6 @@ struct WebEmbeddedWorkerStartData { ...@@ -56,8 +55,6 @@ struct WebEmbeddedWorkerStartData {
network::mojom::IPAddressSpace address_space; network::mojom::IPAddressSpace address_space;
PrivacyPreferences privacy_preferences;
WebEmbeddedWorkerStartData() : wait_for_debugger_mode(kDontWaitForDebugger) {} WebEmbeddedWorkerStartData() : wait_for_debugger_mode(kDontWaitForDebugger) {}
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment