Skip to content

GitLab

T
tangled
Commit f491eb9a authored by nektar's avatar nektar Committed by Commit bot
Browse files
Options

Make click targets inside links work. 

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2030413002
Cr-Commit-Position: refs/heads/master@{#397760}
parent ff71d680
Hide whitespace changes
Inline Side-by-side
Showing with 92 additions and 4 deletions
third_party/WebKit/LayoutTests/accessibility/image-inside-link.html 0 → 100644
View file @ f491eb9a
<!DOCTYPE html>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
<div id="wrapper1">
<a href="#"><img id="img1" alt="Delicious cake" src="resources/cake.png"></a>
</div>
<script>
async_test(function(t)
{
var axImg = accessibilityController.accessibleElementById("img1");
axImg.addNotificationListener(function(notification) {
if (notification == 'Clicked') {
document.getElementById("wrapper1").style.display = "none";
t.done();
}
});
var img = document.getElementById("img1");
img.addEventListener("click", function(e)
{
img.title = "clicked";
});
img.click();
}, "clicking an image via javascript sends an accessible click event");
</script>
<div id="wrapper2">
<a href="#"><img id="img2" alt="Delicious cake" src="resources/cake.png"></a>
</div>
<script>
async_test(function(t)
{
var axImg = accessibilityController.accessibleElementById("img2");
axImg.addNotificationListener(function(notification) {
if (notification == 'Clicked') {
document.getElementById("wrapper2").style.display = "none";
t.done();
}
});
var img = document.getElementById("img2");
img.addEventListener("click", function(e)
{
img.title = "clicked";
});
eventSender.mouseMoveTo(axImg.x + 10, axImg.y + 10);
eventSender.mouseDown();
eventSender.mouseUp();
}, "clicking an image via mouse events sends an accessible click event");
</script>
<div id="wrapper4">
<a href="#"><img id="img4" alt="Delicious cake" src="resources/cake.png"></a>
</div>
<script>
async_test(function(t)
{
var axEvent = false;
var domEvent = false;
var clickEventHandler = function(e)
{
if (e == 'Clicked')
axEvent = true;
// "which" is a known property on MouseEvent objects.
if (e.which) {
img.title = "clicked";
domEvent = true;
}
if (axEvent && domEvent) {
document.getElementById("wrapper4").style.display = "none";
t.done();
}
};
var axImg = accessibilityController.accessibleElementById("img4");
axImg.addNotificationListener(clickEventHandler);
var img = document.getElementById("img4");
img.addEventListener("click", clickEventHandler);
axImg.press();
}, "clicking an image via accessibility sends both an accessible and a DOM click event");
</script>
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
View file @ f491eb9a
......@@ -2009,10 +2009,11 @@ Element* AXNodeObject::actionElement() const
break;
}
Element* elt = anchorElement();
if (!elt)
elt = mouseButtonListener();
return elt;
Element* anchor = anchorElement();
Element* clickElement = mouseButtonListener();
if (!anchor || (clickElement && clickElement->isDescendantOf(anchor)))
return clickElement;
return anchor;
}
Element* AXNodeObject::anchorElement() const
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment