Commit f4a5045f authored by Bettina's avatar Bettina Committed by Commit Bot

Add saved password domain for logging.

chrome://password-manager-internals logs domains
for password reuse. Password protection will be
expanded to use saved passwords so this will be
useful for debugging.

Bug: 1010764
Change-Id: Ie26f80740c711326e179c01762439223dfc57d8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846666
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: default avatarVadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703825}
parent 8d1685b9
...@@ -90,28 +90,32 @@ void PasswordReuseDetectionManager::OnReuseFound( ...@@ -90,28 +90,32 @@ void PasswordReuseDetectionManager::OnReuseFound(
const std::vector<std::string>& matching_domains, const std::vector<std::string>& matching_domains,
int saved_passwords) { int saved_passwords) {
reuse_on_this_page_was_found_ = true; reuse_on_this_page_was_found_ = true;
std::unique_ptr<BrowserSavePasswordProgressLogger> logger;
metrics_util::PasswordType reused_password_type = GetReusedPasswordType( metrics_util::PasswordType reused_password_type = GetReusedPasswordType(
reused_protected_password_hash, matching_domains.size()); reused_protected_password_hash, matching_domains.size());
if (password_manager_util::IsLoggingActive(client_)) { if (password_manager_util::IsLoggingActive(client_)) {
logger.reset( BrowserSavePasswordProgressLogger logger(client_->GetLogManager());
new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
std::vector<std::string> domains_to_log(matching_domains); std::vector<std::string> domains_to_log(matching_domains);
if (reused_password_type == switch (reused_password_type) {
metrics_util::PasswordType::PRIMARY_ACCOUNT_PASSWORD) { case metrics_util::PasswordType::PRIMARY_ACCOUNT_PASSWORD:
domains_to_log.push_back("CHROME SYNC PASSWORD"); domains_to_log.push_back("CHROME SYNC PASSWORD");
} else if (reused_password_type == break;
metrics_util::PasswordType::OTHER_GAIA_PASSWORD) { case metrics_util::PasswordType::OTHER_GAIA_PASSWORD:
domains_to_log.push_back("OTHER GAIA PASSWORD"); domains_to_log.push_back("OTHER GAIA PASSWORD");
} else if (reused_password_type == break;
metrics_util::PasswordType::ENTERPRISE_PASSWORD) { case metrics_util::PasswordType::ENTERPRISE_PASSWORD:
domains_to_log.push_back("ENTERPRISE PASSWORD"); domains_to_log.push_back("ENTERPRISE PASSWORD");
break;
case metrics_util::PasswordType::SAVED_PASSWORD:
domains_to_log.push_back("SAVED PASSWORD");
break;
default:
break;
} }
// TODO(nparker): Implement LogList() to log all domains in one call.
for (const auto& domain : domains_to_log) { for (const auto& domain : domains_to_log) {
logger->LogString(BrowserSavePasswordProgressLogger::STRING_REUSE_FOUND, logger.LogString(BrowserSavePasswordProgressLogger::STRING_REUSE_FOUND,
domain); domain);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment