Mark sync_pb::AppListSpecifics::TYPE_URL obsolete

"TODO... implement" has stayed unimplemented since 2014 (commit 630a27a6,
https://codereview.chromium.org/118463002)

Change-Id: I944d5d8c1e226f221e5c3c4f4a85d8f421a291e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716398
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#681130}

chrome/browser/ui/app_list/app_list_syncable_service.cc

@@ -1113,9 +1113,7 @@ void AppListSyncableService::ProcessNewSyncItem(SyncItem* sync_item) {
           false);                 // It's a folder itself.
       return;
     }
-    case sync_pb::AppListSpecifics::TYPE_URL: {
-      // TODO(stevenjb): Implement
-      LOG(WARNING) << "TYPE_URL not supported";
+    case sync_pb::AppListSpecifics::TYPE_OBSOLETE_URL: {
       return;
     }
     case sync_pb::AppListSpecifics::TYPE_PAGE_BREAK: {

components/sync/protocol/app_list_specifics.proto

@@ -18,25 +18,27 @@ message AppListSpecifics {
   // Unique identifier for the item:
   // * TYPE_FOLDER: Folder id (generated)
   // * TYPE_APP: App Id
-  // * TYPE_URL: Url
   optional string item_id = 1;
 
   // What type of item this is.
   enum AppListItemType {
-    // An extension app.
+    // An app, whether a web app, Android app, etc.
+    //
+    // For bookmark apps (URL shortcuts), additional information such as their
+    // URLs are kept in the AppSpecifics.bookmark_app_foobar fields.
     TYPE_APP = 1;
     // A request to remove any matching default installed apps.
     TYPE_REMOVE_DEFAULT_APP = 2;
     // A folder containing entries whose |parent_id| matches |item_id|.
     TYPE_FOLDER = 3;
-    // A URL shortcut (functionally equivalent to a bookmark).
-    TYPE_URL = 4;
+    // Obsolete type, intended for URL shortcuts, that was never implemented.
+    TYPE_OBSOLETE_URL = 4;
     // A "page break" item (Indicate creation of a new page in app list).
     TYPE_PAGE_BREAK = 5;
   }
   optional AppListItemType item_type = 2;
 
-  // Item name (FOLDER or URL).
+  // Item name (FOLDER).
   optional string item_name = 3;
 
   // Id of the parent (folder) item.

components/sync/protocol/proto_enum_conversions.cc

@@ -26,7 +26,7 @@ const char* ProtoEnumToString(
     ENUM_CASE(sync_pb::AppListSpecifics, TYPE_APP);
     ENUM_CASE(sync_pb::AppListSpecifics, TYPE_REMOVE_DEFAULT_APP);
     ENUM_CASE(sync_pb::AppListSpecifics, TYPE_FOLDER);
-    ENUM_CASE(sync_pb::AppListSpecifics, TYPE_URL);
+    ENUM_CASE(sync_pb::AppListSpecifics, TYPE_OBSOLETE_URL);
     ENUM_CASE(sync_pb::AppListSpecifics, TYPE_PAGE_BREAK);
   }
   NOTREACHED();