Commit f4f8f447 authored by manuk's avatar manuk Committed by Commit Bot

[omnibox] Add unit test for document provider min query length.

Bug: 1004857
Change-Id: I79c0507702ce816ea472943b72418273a468de62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808806
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697326}
parent 6330e730
...@@ -104,6 +104,7 @@ class DocumentProvider : public AutocompleteProvider { ...@@ -104,6 +104,7 @@ class DocumentProvider : public AutocompleteProvider {
FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, GenerateLastModifiedString); FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, GenerateLastModifiedString);
FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, Scoring); FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, Scoring);
FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, Caching); FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, Caching);
FRIEND_TEST_ALL_PREFIXES(DocumentProviderTest, MinQueryLength);
using MatchesCache = base::MRUCache<GURL, AutocompleteMatch>; using MatchesCache = base::MRUCache<GURL, AutocompleteMatch>;
......
...@@ -916,3 +916,29 @@ TEST_F(DocumentProviderTest, Caching) { ...@@ -916,3 +916,29 @@ TEST_F(DocumentProviderTest, Caching) {
testing::ElementsAre(ACMatchClassification{0, 2}, testing::ElementsAre(ACMatchClassification{0, 2},
ACMatchClassification{5, 0})); ACMatchClassification{5, 0}));
} }
TEST_F(DocumentProviderTest, MinQueryLength) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(omnibox::kDocumentProvider);
EXPECT_CALL(*client_.get(), SearchSuggestEnabled())
.WillRepeatedly(Return(true));
EXPECT_CALL(*client_.get(), IsAuthenticated()).WillRepeatedly(Return(true));
EXPECT_CALL(*client_.get(), IsSyncActive()).WillRepeatedly(Return(true));
EXPECT_CALL(*client_.get(), IsOffTheRecord()).WillRepeatedly(Return(false));
// Expect document provider to ignore inputs shorter than min_query_length_.
AutocompleteInput short_input(base::ASCIIToUTF16("12"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
short_input.set_want_asynchronous_matches(false);
provider_->Start(short_input, false);
EXPECT_NE(short_input.text(), provider_->input_.text());
// Expect document provider to process inputs longer than min_query_length_.
AutocompleteInput long_input(base::ASCIIToUTF16("123456"),
metrics::OmniboxEventProto::OTHER,
TestSchemeClassifier());
long_input.set_want_asynchronous_matches(false);
provider_->Start(long_input, false);
EXPECT_EQ(long_input.text(), provider_->input_.text());
}
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment