Safety check: added metrics recording when safety check is started

Bug: 1015841
Change-Id: I6c2d3a4ce305ef0ab5bf0dc36bfff27093c9717f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087584Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Andrey Zaytsev <andzaytsev@google.com>
Cr-Commit-Position: refs/heads/master@{#747158}

chrome/browser/ui/webui/settings/safety_check_handler.cc

@@ -5,6 +5,8 @@
 #include "chrome/browser/ui/webui/settings/safety_check_handler.h"
 
 #include "base/bind.h"
+#include "base/metrics/user_metrics.h"
+#include "base/metrics/user_metrics_action.h"
 #include "chrome/browser/password_manager/bulk_leak_check_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "components/prefs/pref_service.h"
@@ -54,6 +56,7 @@ SafetyCheckHandler::~SafetyCheckHandler() = default;
 
 void SafetyCheckHandler::PerformSafetyCheck() {
   AllowJavascript();
+  base::RecordAction(base::UserMetricsAction("SafetyCheck.Started"));
   if (!version_updater_) {
     version_updater_.reset(VersionUpdater::Create(web_ui()->GetWebContents()));
   }

chrome/browser/ui/webui/settings/safety_check_handler_unittest.cc

@@ -6,6 +6,7 @@
 
 #include "base/bind.h"
 #include "base/optional.h"
+#include "base/test/metrics/user_action_tester.h"
 #include "chrome/browser/ui/webui/help/test_version_updater.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/password_manager/core/browser/bulk_leak_check_service.h"
@@ -89,6 +90,12 @@ bool SafetyCheckHandlerTest::HasSafetyCheckStatusChangedWithData(
   return false;
 }
 
+TEST_F(SafetyCheckHandlerTest, PerformSafetyCheck_MetricsRecorded) {
+  base::UserActionTester user_action_tester;
+  safety_check_->PerformSafetyCheck();
+  EXPECT_EQ(1, user_action_tester.GetActionCount("SafetyCheck.Started"));
+}
+
 TEST_F(SafetyCheckHandlerTest, CheckUpdates_Updated) {
   version_updater_->SetReturnedStatus(VersionUpdater::Status::UPDATED);
   safety_check_->PerformSafetyCheck();

tools/metrics/actions/actions.xml

@@ -18294,6 +18294,12 @@ should be able to be added at any place in this file.
   </description>
 </action>
 
+<action name="SafetyCheck.Started">
+  <owner>andzaytsev@google.com</owner>
+  <owner>msramek@chromium.org</owner>
+  <description>User started a browser safety check in settings.</description>
+</action>
+
 <action name="Save">
   <owner>Please list the metric's owners. Add more owner tags as needed.</owner>
   <description>Please enter the description of this user action.</description>