Commit f522563b authored by jsbell's avatar jsbell Committed by Commit bot

FileAPI: Remove TODOs around readAsBinaryString - it's back in the spec

FileReader.readAsBinaryString() was removed from the spec after typed
arrays became a thing. But all browsers kept shipping it, and it looks
risky to remove, so it was added back to the spec. Remove the use
counters and TODOs in the IDL files.

R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2171953002
Cr-Commit-Position: refs/heads/master@{#407202}
parent 67a627d5
......@@ -40,9 +40,7 @@
] interface FileReader : EventTarget {
// async read methods
[RaisesException] void readAsArrayBuffer(Blob blob);
// TODO(foolip): readAsBinaryString() was removed from the spec in 2012:
// https://github.com/w3c/FileAPI/commit/8cce54559dc27bf8b8244f3f0ca9fb3e4d96efdb
[RaisesException, Measure] void readAsBinaryString(Blob blob);
[RaisesException] void readAsBinaryString(Blob blob);
[RaisesException] void readAsText(Blob blob, optional DOMString label);
[RaisesException] void readAsDataURL(Blob blob);
......
......@@ -35,9 +35,7 @@
Constructor,
] interface FileReaderSync {
[CallWith=ExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
// TODO(foolip): readAsBinaryString() was removed from the spec in 2012:
// https://github.com/w3c/FileAPI/commit/8cce54559dc27bf8b8244f3f0ca9fb3e4d96efdb
[CallWith=ExecutionContext, RaisesException, Measure] DOMString readAsBinaryString(Blob blob);
[CallWith=ExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);
[CallWith=ExecutionContext, RaisesException] DOMString readAsText(Blob blob, optional DOMString label);
[CallWith=ExecutionContext, RaisesException] DOMString readAsDataURL(Blob blob);
};
......@@ -639,8 +639,6 @@ public:
V8HTMLLinkElement_Disabled_AttributeSetter = 811,
V8HTMLStyleElement_Disabled_AttributeGetter = 812,
V8HTMLStyleElement_Disabled_AttributeSetter = 813,
V8FileReader_ReadAsBinaryString_Method = 814,
V8FileReaderSync_ReadAsBinaryString_Method = 815,
V8DOMError_Constructor = 816,
V8DOMError_Name_AttributeGetter = 817,
V8DOMError_Message_AttributeGetter = 818,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment