Skip to content

GitLab

T
tangled
Commit f52882f2 authored by arthursonzogni's avatar arthursonzogni Committed by Commit Bot
Browse files
Options

Reenable test sandboxed-iframe-plugins.html 

[Note to sheriff]
Feel free to immediately revert this CL if this test is failing
in the next 3 days.

This test was marked flaky 2 years ago, but nobody was assigned or CC.
As a result, it hasn't been properly investigated. This patch enables it again.
If it works, great. If it doesn't work we will get useful data about it.

R=mkwst@chromium.org

Bug: 745887
Change-Id: I0c50d61992dd56a13aee891e4eedfd14c43bc9df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108144
Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: default avatarMike West <mkwst@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#751620}
parent a82d7e7d
Hide whitespace changes
Inline Side-by-side
Showing with 43 additions and 46 deletions
third_party/blink/web_tests/TestExpectations
View file @ f52882f2
......@@ -4816,9 +4816,6 @@ crbug.com/1052642 virtual/cache-storage-high-priority-match/external/wpt/service
# Sheriff failures 2017-07-03
crbug.com/708994 http/tests/security/cross-frame-mouse-source-capabilities.html [ Timeout Pass ]
crbug.com/745887 [ Mac ] fast/frames/sandboxed-iframe-plugins.html [ Failure Pass ]
crbug.com/745887 [ Win ] fast/frames/sandboxed-iframe-plugins.html [ Failure Pass ]
crbug.com/746128 [ Win7 Debug ] media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html [ Failure ]
crbug.com/746128 [ Win7 Debug ] virtual/audio-service/media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html [ Failure ]
crbug.com/746128 [ Mac ] media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html [ Failure Pass ]
......
third_party/blink/web_tests/fast/frames/sandboxed-iframe-plugins.html
View file @ f52882f2
<html>
<html>
<head>
<script src="../../resources/js-test.js"></script>
<script>
if (window.testRunner)
testRunner.dumpAsText();
window.onload = function() {
shouldBeTrue("(self.embedFrame1.document.getElementById('plugin').postMessage) != undefined");
shouldBeTrue("(self.embedFrame2.document.getElementById('plugin').postMessage) == undefined");
<script>
if (window.testRunner)
testRunner.dumpAsText();
window.onload = function() {
shouldBeTrue("(self.embedFrame1.document.getElementById('plugin').postMessage) != undefined");
shouldBeTrue("(self.embedFrame2.document.getElementById('plugin').postMessage) == undefined");
shouldBeTrue("(self.objectFrame1.document.getElementById('plugin').postMessage) != undefined");
shouldBeTrue("(self.objectFrame2.document.getElementById('plugin').postMessage) == undefined");
shouldBeTrue("(self.objectFrame1.document.getElementById('plugin').postMessage) != undefined");
shouldBeTrue("(self.objectFrame2.document.getElementById('plugin').postMessage) == undefined");
isSuccessfullyParsed();
}
isSuccessfullyParsed();
}
</script>
</head>
<body>
<p id="description"></p>
<div id="console"></div>
<!-- Embeds -->
<iframe name="embedFrame1"
style="width: 200px; height: 100px;"
src="resources/sandboxed-iframe-plugins-frame-embed.html">
</iframe>
<iframe name="embedFrame2"
style="width: 200px; height: 100px;"
sandbox="allow-same-origin"
src="resources/sandboxed-iframe-plugins-frame-embed.html">
</iframe>
<!-- Objects -->
<iframe name="objectFrame1"
style="width: 200px; height: 100px;"
src="resources/sandboxed-iframe-plugins-frame-object.html">
</iframe>
<iframe name="objectFrame2"
style="width: 200px; height: 100px;"
sandbox="allow-same-origin"
src="resources/sandboxed-iframe-plugins-frame-object.html">
</iframe>
<script>
description("This test verifies that sandboxing of plugins works as intended. Two tests are made, each in one sandboxed and one non-sandboxed IFrame: embeds and objects.");
</script>
<p id="description"></p>
<div id="console"></div>
<!-- Embeds -->
<iframe name="embedFrame1"
style="width: 200px; height: 100px;"
src="resources/sandboxed-iframe-plugins-frame-embed.html">
</iframe>
<iframe name="embedFrame2"
style="width: 200px; height: 100px;"
sandbox="allow-same-origin"
src="resources/sandboxed-iframe-plugins-frame-embed.html">
</iframe>
<!-- Objects -->
<iframe name="objectFrame1"
style="width: 200px; height: 100px;"
src="resources/sandboxed-iframe-plugins-frame-object.html">
</iframe>
<iframe name="objectFrame2"
style="width: 200px; height: 100px;"
sandbox="allow-same-origin"
src="resources/sandboxed-iframe-plugins-frame-object.html">
</iframe>
<script>
description("This test verifies that sandboxing of plugins works as intended. Two tests are made, each in one sandboxed and one non-sandboxed IFrame: embeds and objects.");
</script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment