Commit f561a7c8 authored by scottmg@chromium.org's avatar scottmg@chromium.org

Remove dependency of common on variations browser code


R=asvitkine@chromium.org
BUG=404809,405295

Review URL: https://codereview.chromium.org/490733002

Cr-Commit-Position: refs/heads/master@{#291293}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291293 0039d316-1c4b-4281-b951-d872f2087c98
parent d5467eb7
...@@ -2872,6 +2872,7 @@ ...@@ -2872,6 +2872,7 @@
# transitively via the common target because the proto sources need to # transitively via the common target because the proto sources need to
# be generated before code in this target can start building. # be generated before code in this target can start building.
'../components/components.gyp:variations', '../components/components.gyp:variations',
'../components/components.gyp:variations_http_provider',
'../components/components.gyp:webdata_common', '../components/components.gyp:webdata_common',
'../content/content.gyp:content_browser', '../content/content.gyp:content_browser',
'../content/content.gyp:content_common', '../content/content.gyp:content_common',
......
...@@ -58,6 +58,7 @@ ...@@ -58,6 +58,7 @@
# transitively via the common target because the proto sources need to # transitively via the common target because the proto sources need to
# be generated before code in this target can start building. # be generated before code in this target can start building.
'../components/components.gyp:variations', '../components/components.gyp:variations',
'../components/components.gyp:variations_http_provider',
'../components/components_strings.gyp:components_strings', '../components/components_strings.gyp:components_strings',
'../content/content.gyp:content_browser', '../content/content.gyp:content_browser',
'../content/content.gyp:content_common', '../content/content.gyp:content_common',
......
...@@ -399,6 +399,7 @@ ...@@ -399,6 +399,7 @@
# Dependencies of variations # Dependencies of variations
'components.gyp:variations', 'components.gyp:variations',
'components.gyp:variations_http_provider',
], ],
'conditions': [ 'conditions': [
['toolkit_views == 1', { ['toolkit_views == 1', {
......
...@@ -12,9 +12,10 @@ ...@@ -12,9 +12,10 @@
'..', '..',
], ],
'dependencies': [ 'dependencies': [
# List of dependencies is intentionally very minimal. Please avoid
# adding extra dependencies without first checking with OWNERS.
'../base/base.gyp:base', '../base/base.gyp:base',
'../third_party/mt19937ar/mt19937ar.gyp:mt19937ar', '../third_party/mt19937ar/mt19937ar.gyp:mt19937ar',
'components.gyp:google_core_browser',
], ],
'sources': [ 'sources': [
'variations/active_field_trials.cc', 'variations/active_field_trials.cc',
...@@ -41,8 +42,6 @@ ...@@ -41,8 +42,6 @@
'variations/study_filtering.h', 'variations/study_filtering.h',
'variations/variations_associated_data.cc', 'variations/variations_associated_data.cc',
'variations/variations_associated_data.h', 'variations/variations_associated_data.h',
'variations/variations_http_header_provider.cc',
'variations/variations_http_header_provider.h',
'variations/variations_seed_processor.cc', 'variations/variations_seed_processor.cc',
'variations/variations_seed_processor.h', 'variations/variations_seed_processor.h',
'variations/variations_seed_simulator.cc', 'variations/variations_seed_simulator.cc',
...@@ -61,6 +60,23 @@ ...@@ -61,6 +60,23 @@
}], }],
], ],
}, },
{
# GN version: //components/variations_http_provider
'target_name': 'variations_http_provider',
'type': 'static_library',
'include_dirs': [
'..',
],
'dependencies': [
'../base/base.gyp:base',
'components.gyp:google_core_browser',
'variations',
],
'sources': [
'variations/variations_http_header_provider.cc',
'variations/variations_http_header_provider.h',
],
},
], ],
'conditions': [ 'conditions': [
['OS=="android"', { ['OS=="android"', {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment