Commit f5758946 authored by Yue Li's avatar Yue Li Committed by Commit Bot

[Assistant Opt-in] Unblock Assistant opt-in flow when network disconnect

Bug: b/158541058
Test: Manual Test
Change-Id: I74300ee103845a66b2acb8c61de59777c3495d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250463
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#780050}
parent dc21c92b
...@@ -259,11 +259,14 @@ void AssistantOptInFlowScreenHandler::OnEmailOptInResult(bool opted_in) { ...@@ -259,11 +259,14 @@ void AssistantOptInFlowScreenHandler::OnEmailOptInResult(bool opted_in) {
return; return;
} }
// TODO(b/159363597): Handle network disconnect when sending email opt-in
// result.
RecordAssistantOptInStatus(opted_in ? EMAIL_OPTED_IN : EMAIL_OPTED_OUT); RecordAssistantOptInStatus(opted_in ? EMAIL_OPTED_IN : EMAIL_OPTED_OUT);
assistant::AssistantSettings::Get()->UpdateSettings( assistant::AssistantSettings::Get()->UpdateSettings(
GetEmailOptInUpdate(opted_in).SerializeAsString(), GetEmailOptInUpdate(opted_in).SerializeAsString(),
base::BindOnce(&AssistantOptInFlowScreenHandler::OnUpdateSettingsResponse, base::BindOnce(&AssistantOptInFlowScreenHandler::OnUpdateSettingsResponse,
weak_factory_.GetWeakPtr())); weak_factory_.GetWeakPtr()));
HandleFlowFinished();
} }
void AssistantOptInFlowScreenHandler::OnDialogClosed() { void AssistantOptInFlowScreenHandler::OnDialogClosed() {
...@@ -477,7 +480,6 @@ void AssistantOptInFlowScreenHandler::OnUpdateSettingsResponse( ...@@ -477,7 +480,6 @@ void AssistantOptInFlowScreenHandler::OnUpdateSettingsResponse(
// TODO(updowndta): Handle email optin update failure. // TODO(updowndta): Handle email optin update failure.
LOG(ERROR) << "Email OptIn udpate error."; LOG(ERROR) << "Email OptIn udpate error.";
} }
HandleFlowFinished();
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment