Commit f5a7f44e authored by David Grogan's avatar David Grogan Committed by Commit Bot

[css-tables] Speculative workaround for crash

RecalcVisualOverflow might be trying to read a cell that's been removed
from the tree.

I've not been able to get this to repro on android or linux.

Bug: 956625
Change-Id: I1353bd537245fc458e9eeec48bd8861b70364cf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617559Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661121}
parent 59f5aa7b
...@@ -1742,6 +1742,7 @@ unsigned LayoutTableSection::NumEffectiveColumns() const { ...@@ -1742,6 +1742,7 @@ unsigned LayoutTableSection::NumEffectiveColumns() const {
LayoutTableCell* LayoutTableSection::OriginatingCellAt( LayoutTableCell* LayoutTableSection::OriginatingCellAt(
unsigned row, unsigned row,
unsigned effective_column) { unsigned effective_column) {
SECURITY_CHECK(!needs_cell_recalc_);
if (effective_column >= NumCols(row)) if (effective_column >= NumCols(row))
return nullptr; return nullptr;
auto& grid_cell = GridCellAt(row, effective_column); auto& grid_cell = GridCellAt(row, effective_column);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment