Commit f5b82d91 authored by Maggie Cai's avatar Maggie Cai Committed by Commit Bot

Settings: Stop repopulate the all sites list on permission changes.

Currently on permission changes, the all sites list will be
re-populated. This is a issue when we reset the permission for an
etld+1. Because this resets every single permission settings for all the
origins under the etld+1, which triggers 16*n (n=number of origins) on
permission changes, therefore makes the all sites list repopulate that
many time. This affect the performance, also make the list jump back to
the top and lost the last selected entry. This CL removes the event
listener for permission change in all sites page. In the future, we
should implement the similar banner with reload when permission changes
from other places (not all sites page) occurs.

BUG=835712

Change-Id: I54596b1ba7d9901bdcd3ddd2192c1a0973aa5acf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496118Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637608}
parent d6bfeb0d
...@@ -127,8 +127,6 @@ Polymer({ ...@@ -127,8 +127,6 @@ Polymer({
ready: function() { ready: function() {
this.addWebUIListener( this.addWebUIListener(
'onStorageListFetched', this.onStorageListFetched.bind(this)); 'onStorageListFetched', this.onStorageListFetched.bind(this));
this.addWebUIListener(
'contentSettingSitePermissionChanged', this.populateList_.bind(this));
this.addEventListener( this.addEventListener(
'site-entry-selected', 'site-entry-selected',
(/** @type {!CustomEvent<!{item: !SiteGroup, index: number}>} */ e) => { (/** @type {!CustomEvent<!{item: !SiteGroup, index: number}>} */ e) => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment