Commit f5e1ad05 authored by Olivier Robin's avatar Olivier Robin Committed by Commit Bot

Reenable RL tests

Bug: 1047236, 1046998
Change-Id: Ib9d6812d50e0fc55739f3a866cbf79e4f44786c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072159Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744576}
parent f1123f5e
...@@ -447,10 +447,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) { ...@@ -447,10 +447,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) {
// appearing, and that the Reading List entry is present in the Reading List. // appearing, and that the Reading List entry is present in the Reading List.
// Loads offline version via context menu. // Loads offline version via context menu.
- (void)testSavingToReadingListAndLoadDistilled { - (void)testSavingToReadingListAndLoadDistilled {
// TODO(crbug.com/1047236): Test fails when run on iOS 13.
if (@available(iOS 13, *)) {
EARL_GREY_TEST_DISABLED(@"Fails on iOS 13.");
}
[ReadingListAppInterface forceConnectionToWifi]; [ReadingListAppInterface forceConnectionToWifi];
GURL distillablePageURL(self.testServer->GetURL(kDistillableURL)); GURL distillablePageURL(self.testServer->GetURL(kDistillableURL));
GURL nonDistillablePageURL(self.testServer->GetURL(kNonDistillableURL)); GURL nonDistillablePageURL(self.testServer->GetURL(kNonDistillableURL));
...@@ -530,10 +526,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) { ...@@ -530,10 +526,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) {
// appearing, and that the Reading List entry is present in the Reading List. // appearing, and that the Reading List entry is present in the Reading List.
// Loads offline version by tapping on entry without web server. // Loads offline version by tapping on entry without web server.
- (void)testSavingToReadingListAndLoadNoNetwork { - (void)testSavingToReadingListAndLoadNoNetwork {
// TODO(crbug.com/1046998): Flaky on iOS 13.1.
if (@available(iOS 13.1, *)) {
EARL_GREY_TEST_DISABLED(@"Fails on iOS 13.1.");
}
[ReadingListAppInterface forceConnectionToWifi]; [ReadingListAppInterface forceConnectionToWifi];
GURL distillableURL = self.testServer->GetURL(kDistillableURL); GURL distillableURL = self.testServer->GetURL(kDistillableURL);
// Open http://potato // Open http://potato
...@@ -580,10 +572,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) { ...@@ -580,10 +572,6 @@ void AssertIsShowingDistillablePage(bool online, const GURL& distillable_url) {
// appearing, and that the Reading List entry is present in the Reading List. // appearing, and that the Reading List entry is present in the Reading List.
// Loads offline version by tapping on entry with delayed web server. // Loads offline version by tapping on entry with delayed web server.
- (void)testSavingToReadingListAndLoadBadNetwork { - (void)testSavingToReadingListAndLoadBadNetwork {
// TODO(crbug.com/1046998): Flaky on iOS 13.1.
if (@available(iOS 13.1, *)) {
EARL_GREY_TEST_DISABLED(@"Fails on iOS 13.1.");
}
[ReadingListAppInterface forceConnectionToWifi]; [ReadingListAppInterface forceConnectionToWifi];
GURL distillableURL = self.testServer->GetURL(kDistillableURL); GURL distillableURL = self.testServer->GetURL(kDistillableURL);
// Open http://potato // Open http://potato
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment