Commit f5e4ae45 authored by Phillis Tang's avatar Phillis Tang Committed by Chromium LUCI CQ

IPH: do not override GetBubbleBounds

Remove |FeaturePromoBubbleView::GetBubbleBounds| override as it's not
needed anymore.

Change-Id: I0c8ebd04982889842494c7a85b68f902a0832b33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622733
Commit-Queue: Phillis Tang <phillis@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: default avatarCollin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842269}
parent e7a54b0e
...@@ -316,17 +316,6 @@ void FeaturePromoBubbleView::OnMouseExited(const ui::MouseEvent& event) { ...@@ -316,17 +316,6 @@ void FeaturePromoBubbleView::OnMouseExited(const ui::MouseEvent& event) {
feature_promo_bubble_timeout_->OnMouseExited(); feature_promo_bubble_timeout_->OnMouseExited();
} }
gfx::Rect FeaturePromoBubbleView::GetBubbleBounds() {
gfx::Rect bounds = BubbleDialogDelegateView::GetBubbleBounds();
if (!focusable_) {
if (base::i18n::IsRTL())
bounds.Offset(5, 0);
else
bounds.Offset(-5, 0);
}
return bounds;
}
ax::mojom::Role FeaturePromoBubbleView::GetAccessibleWindowRole() { ax::mojom::Role FeaturePromoBubbleView::GetAccessibleWindowRole() {
// Since we don't have any controls for the user to interact with (we're just // Since we don't have any controls for the user to interact with (we're just
// an information bubble), override our role to kAlert. // an information bubble), override our role to kAlert.
......
...@@ -15,9 +15,6 @@ ...@@ -15,9 +15,6 @@
#include "ui/gfx/geometry/rect.h" #include "ui/gfx/geometry/rect.h"
#include "ui/views/bubble/bubble_dialog_delegate_view.h" #include "ui/views/bubble/bubble_dialog_delegate_view.h"
namespace gfx {
class Rect;
}
namespace ui { namespace ui {
class MouseEvent; class MouseEvent;
...@@ -89,7 +86,6 @@ class FeaturePromoBubbleView : public views::BubbleDialogDelegateView { ...@@ -89,7 +86,6 @@ class FeaturePromoBubbleView : public views::BubbleDialogDelegateView {
bool OnMousePressed(const ui::MouseEvent& event) override; bool OnMousePressed(const ui::MouseEvent& event) override;
void OnMouseEntered(const ui::MouseEvent& event) override; void OnMouseEntered(const ui::MouseEvent& event) override;
void OnMouseExited(const ui::MouseEvent& event) override; void OnMouseExited(const ui::MouseEvent& event) override;
gfx::Rect GetBubbleBounds() override;
ax::mojom::Role GetAccessibleWindowRole() override; ax::mojom::Role GetAccessibleWindowRole() override;
base::string16 GetAccessibleWindowTitle() const override; base::string16 GetAccessibleWindowTitle() const override;
void UpdateHighlightedButton(bool highlighted) override { void UpdateHighlightedButton(bool highlighted) override {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment