Commit f5eaea65 authored by Orin Jaworski's avatar Orin Jaworski Committed by Commit Bot

Revert "[omnibox] Fix pedal buttons misplacement"

This reverts commit f0b702c0.

Reason for revert: The CL being reverted was attempting to fix a presentation issue, but ended up breaking mouse handling for all button row buttons.

Original change's description:
> [omnibox] Fix pedal buttons misplacement
> 
> The first time when match changes its height, pedal button is misplaced
> and overlaps with another match. This was caused by setting wrong bounds
> for button row.
> 
> Bug: 1121934
> Change-Id: I297a3551c370f8efd7c4079e14b9c6fcace70e84
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385378
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
> Cr-Commit-Position: refs/heads/master@{#803217}

TBR=tommycli@chromium.org,bsep@chromium.org,olesiamarukhno@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1121934
Change-Id: Ic32e7cc083e06285348a2857e201d1da268de077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391107Reviewed-by: default avatarOrin Jaworski <orinj@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804072}
parent fc33ef5c
...@@ -413,9 +413,10 @@ void OmniboxResultView::Layout() { ...@@ -413,9 +413,10 @@ void OmniboxResultView::Layout() {
// TODO(orinj): Determine and use the best way to set bounds; probably // TODO(orinj): Determine and use the best way to set bounds; probably
// GetPreferredSize() with a layout manager. // GetPreferredSize() with a layout manager.
// Put it below the suggestion view. // Put it below the suggestion view.
button_row_->SetBounds(0, suggestion_height, button_row_->SetBounds(0, button_row_->height(),
suggestion_width - suggestion_indent, suggestion_width - suggestion_indent,
button_row_->height()); suggestion_height);
button_row_->Layout();
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment