Clipboard Text Suggestion should never use favicon

Bug: 1020609
Change-Id: I84fb6c13ca3ab0d3002853b17772775a7ff3eb54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895968Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711885}

chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/basic/BasicSuggestionProcessor.java

@@ -214,7 +214,9 @@ public class BasicSuggestionProcessor implements SuggestionProcessor {
         model.set(SuggestionViewProperties.TEXT_LINE_2_MAX_LINES, 1);
 
         // Include site favicon if we are presenting URL and have favicon available.
-        if (mLargeIconBridge != null && suggestion.getUrl() != null) {
+        // TODO(gangwu): Create a saparate processor for clipboard suggestions.
+        if (mLargeIconBridge != null && suggestion.getUrl() != null
+                && suggestion.getType() != OmniboxSuggestionType.CLIPBOARD_TEXT) {
             mLargeIconBridge.getLargeIconForUrl(suggestion.getUrl(), mDesiredFaviconWidthPx,
                     (Bitmap icon, int fallbackColor, boolean isFallbackColorDefault,
                             int iconType) -> {