Commit f64bcfb1 authored by Martin Barbella's avatar Martin Barbella Committed by Commit Bot

Minor IPC fuzzer fixes:

1) Favor --renderer-cmd-prefix more heavil when generating flags files
for ClusterFuzz.
2) Remove the --gpu-launcher option as it no longer works. Looking at
existing issues I'm not sure that this is too important for our
coverage, so it seems easier to remove it than to try to continue
maintaining it.

R=inferno@chromium.org

Bug: 904773
Change-Id: I3f0f468337540dfc5af73289ad0a46e41dcdb5ae
Reviewed-on: https://chromium-review.googlesource.com/c/1340978Reviewed-by: default avatarAbhishek Arya <inferno@chromium.org>
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609703}
parent 29240d10
...@@ -87,7 +87,6 @@ def main(): ...@@ -87,7 +87,6 @@ def main():
prefixes = { prefixes = {
'--renderer-cmd-prefix', '--renderer-cmd-prefix',
'--gpu-launcher',
'--plugin-launcher', '--plugin-launcher',
'--ppapi-plugin-launcher', '--ppapi-plugin-launcher',
'--utility-cmd-prefix', '--utility-cmd-prefix',
......
...@@ -17,11 +17,13 @@ FUZZ_PREFIX = 'fuzz-' ...@@ -17,11 +17,13 @@ FUZZ_PREFIX = 'fuzz-'
IPC_FUZZER_APPLICATION = 'ipc_fuzzer' IPC_FUZZER_APPLICATION = 'ipc_fuzzer'
IPC_REPLAY_APPLICATION = 'ipc_fuzzer_replay' IPC_REPLAY_APPLICATION = 'ipc_fuzzer_replay'
IPCDUMP_EXTENSION = '.ipcdump' IPCDUMP_EXTENSION = '.ipcdump'
LAUNCH_PREFIXES = [ UNCOMMON_PREFIX_CHANCE = 10 # 1 in 10
'--gpu-launcher', COMMON_LAUNCH_PREFIXES = [
'--renderer-cmd-prefix',
]
UNCOMMON_LAUNCH_PEFIXES = [
'--plugin-launcher', '--plugin-launcher',
'--ppapi-plugin-launcher', '--ppapi-plugin-launcher',
'--renderer-cmd-prefix',
'--utility-cmd-prefix', '--utility-cmd-prefix',
] ]
...@@ -35,7 +37,10 @@ def application_name_for_platform(application_name): ...@@ -35,7 +37,10 @@ def application_name_for_platform(application_name):
def create_flags_file(ipcdump_testcase_path): def create_flags_file(ipcdump_testcase_path):
"""Create a flags file to add launch prefix to application command line.""" """Create a flags file to add launch prefix to application command line."""
random_launch_prefix = random.choice(LAUNCH_PREFIXES) prefixes = (UNCOMMON_LAUNCH_PREFIXES if
random.randint(1, UNCOMMON_PREFIX_CHANCE) == 1 else
COMMON_LAUNCH_PREFIXES)
random_launch_prefix = random.choice(prefixes)
application_name = application_name_for_platform(IPC_REPLAY_APPLICATION) application_name = application_name_for_platform(IPC_REPLAY_APPLICATION)
file_content = '%s=%%APP_DIR%%%s%s' % (random_launch_prefix, os.path.sep, file_content = '%s=%%APP_DIR%%%s%s' % (random_launch_prefix, os.path.sep,
application_name) application_name)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment