Commit f6676c19 authored by Austin Sullivan's avatar Austin Sullivan Committed by Chromium LUCI CQ

Tidy: Rename commented arg tmp_path -> tmp_path_literal

Bug: N/A
Change-Id: I403af0c25c2c3b1354cbb5f4fcd07dd9757c16ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602109
Auto-Submit: Austin Sullivan <asully@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: default avatarDaniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#840194}
parent bf4f83d9
...@@ -3220,8 +3220,8 @@ TEST_P(DeepScanningDownloadTest, UnsupportedFiletypeBlockedByPreference) { ...@@ -3220,8 +3220,8 @@ TEST_P(DeepScanningDownloadTest, UnsupportedFiletypeBlockedByPreference) {
TEST_F(DownloadProtectionServiceTest, NativeFileSystemWriteRequest_NotABinary) { TEST_F(DownloadProtectionServiceTest, NativeFileSystemWriteRequest_NotABinary) {
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
RunLoop run_loop; RunLoop run_loop;
download_service_->CheckNativeFileSystemWrite( download_service_->CheckNativeFileSystemWrite(
...@@ -3239,8 +3239,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3239,8 +3239,8 @@ TEST_F(DownloadProtectionServiceTest,
PrepareResponse(ClientDownloadResponse::DANGEROUS, net::HTTP_OK, net::OK); PrepareResponse(ClientDownloadResponse::DANGEROUS, net::HTTP_OK, net::OK);
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _)) EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _))
.Times(1); .Times(1);
...@@ -3272,8 +3272,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3272,8 +3272,8 @@ TEST_F(DownloadProtectionServiceTest,
// Case (2): is_extended_reporting && !is_incognito. // Case (2): is_extended_reporting && !is_incognito.
// A "light" ClientDownloadRequest should be sent. // A "light" ClientDownloadRequest should be sent.
item = PrepareBasicNativeFileSystemWriteItem( item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
RunLoop run_loop; RunLoop run_loop;
download_service_->CheckNativeFileSystemWrite( download_service_->CheckNativeFileSystemWrite(
std::move(item), std::move(item),
...@@ -3300,8 +3300,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3300,8 +3300,8 @@ TEST_F(DownloadProtectionServiceTest,
// ClientDownloadRequest should NOT be sent. // ClientDownloadRequest should NOT be sent.
SetExtendedReportingPreference(false); SetExtendedReportingPreference(false);
item = PrepareBasicNativeFileSystemWriteItem( item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
item->browser_context = profile()->GetPrimaryOTRProfile(); item->browser_context = profile()->GetPrimaryOTRProfile();
RunLoop run_loop; RunLoop run_loop;
...@@ -3317,8 +3317,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3317,8 +3317,8 @@ TEST_F(DownloadProtectionServiceTest,
// Case (4): !is_extended_reporting && !is_incognito. // Case (4): !is_extended_reporting && !is_incognito.
// ClientDownloadRequest should NOT be sent. // ClientDownloadRequest should NOT be sent.
item = PrepareBasicNativeFileSystemWriteItem( item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
RunLoop run_loop; RunLoop run_loop;
download_service_->CheckNativeFileSystemWrite( download_service_->CheckNativeFileSystemWrite(
std::move(item), std::move(item),
...@@ -3337,8 +3337,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3337,8 +3337,8 @@ TEST_F(DownloadProtectionServiceTest,
net::ERR_FAILED); net::ERR_FAILED);
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.exe.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.exe.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.exe")); /*final_path_literal=*/FILE_PATH_LITERAL("a.exe"));
EXPECT_CALL(*sb_service_->mock_database_manager(), EXPECT_CALL(*sb_service_->mock_database_manager(),
MatchDownloadWhitelistUrl(_)) MatchDownloadWhitelistUrl(_))
...@@ -3360,8 +3360,8 @@ TEST_F(DownloadProtectionServiceTest, NativeFileSystemWriteRequest_Success) { ...@@ -3360,8 +3360,8 @@ TEST_F(DownloadProtectionServiceTest, NativeFileSystemWriteRequest_Success) {
PrepareResponse(ClientDownloadResponse::SAFE, net::HTTP_OK, net::OK); PrepareResponse(ClientDownloadResponse::SAFE, net::HTTP_OK, net::OK);
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.exe.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.exe.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.exe")); /*final_path_literal=*/FILE_PATH_LITERAL("a.exe"));
EXPECT_CALL(*sb_service_->mock_database_manager(), EXPECT_CALL(*sb_service_->mock_database_manager(),
MatchDownloadWhitelistUrl(_)) MatchDownloadWhitelistUrl(_))
...@@ -3434,8 +3434,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3434,8 +3434,8 @@ TEST_F(DownloadProtectionServiceTest,
AddDomainToEnterpriseWhitelist("example.com"); AddDomainToEnterpriseWhitelist("example.com");
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.txt.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.txt.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.txt")); /*final_path_literal=*/FILE_PATH_LITERAL("a.txt"));
item->frame_url = GURL("https://example.com/foo"); item->frame_url = GURL("https://example.com/foo");
download_service_->CheckNativeFileSystemWrite( download_service_->CheckNativeFileSystemWrite(
std::move(item), std::move(item),
...@@ -3451,8 +3451,8 @@ TEST_F(DownloadProtectionServiceTest, ...@@ -3451,8 +3451,8 @@ TEST_F(DownloadProtectionServiceTest,
TEST_F(DownloadProtectionServiceTest, TEST_F(DownloadProtectionServiceTest,
NativeFileSystemWriteRequest_CheckRequest) { NativeFileSystemWriteRequest_CheckRequest) {
auto item = PrepareBasicNativeFileSystemWriteItem( auto item = PrepareBasicNativeFileSystemWriteItem(
/*tmp_path=*/FILE_PATH_LITERAL("a.exe.crswap"), /*tmp_path_literal=*/FILE_PATH_LITERAL("a.exe.crswap"),
/*final_path=*/FILE_PATH_LITERAL("a.exe")); /*final_path_literal=*/FILE_PATH_LITERAL("a.exe"));
item->frame_url = GURL("http://www.google.com/"); item->frame_url = GURL("http://www.google.com/");
GURL tab_url("http://tab.com/final"); GURL tab_url("http://tab.com/final");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment