Commit f6913b20 authored by Gauthier Ambard's avatar Gauthier Ambard Committed by Commit Bot

Disable failing test

Those tests are failing on ios.

TBR: mahmadi@chromium.org
Bug: 1151909
Change-Id: I14352880508aebb0a2b4ace675d45c7f6e61e52f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560096
Auto-Submit: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: default avatarOlivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830948}
parent 549f71af
......@@ -338,7 +338,13 @@ void RepeatableQueriesServiceTest::OnRepeatableQueriesServiceShuttingDown() {
service_->RemoveObserver(this);
}
TEST_F(RepeatableQueriesServiceTest, SignedIn) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn DISABLED_SignedIn
#else
#define MAYBE_SignedIn SignedIn
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedIn) {
SignIn();
test_url_loader_factory()->AddResponse(service()->GetRequestURL().spec(),
GoodServerResponse());
......@@ -357,7 +363,13 @@ TEST_F(RepeatableQueriesServiceTest, SignedIn) {
EXPECT_EQ(expected_server_queries, service()->repeatable_queries());
}
TEST_F(RepeatableQueriesServiceTest, SignedIn_BadResponse) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn_BadResponse DISABLED_SignedIn_BadResponse
#else
#define MAYBE_SignedIn_BadResponse SignedIn_BadResponse
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedIn_BadResponse) {
SignIn();
test_url_loader_factory()->AddResponse(service()->GetRequestURL().spec(),
GoodServerResponse());
......@@ -391,8 +403,8 @@ TEST_F(RepeatableQueriesServiceTest, SignedIn_BadResponse) {
EXPECT_TRUE(service()->repeatable_queries().empty());
}
// TODO(crbug.com/1151909) Test fails on iOS device
#if defined(OS_IOS) && !TARGET_IPHONE_SIMULATOR
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn_ErrorResponse DISABLED_SignedIn_ErrorResponse
#else
#define MAYBE_SignedIn_ErrorResponse SignedIn_ErrorResponse
......@@ -424,8 +436,8 @@ TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedIn_ErrorResponse) {
EXPECT_EQ(expected_server_queries, service()->repeatable_queries());
}
// TODO(crbug.com/1151909) Test fails on iOS device
#if defined(OS_IOS) && !TARGET_IPHONE_SIMULATOR
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn_DefaultSearchProviderChanged \
DISABLED_SignedIn_DefaultSearchProviderChanged
#else
......@@ -458,7 +470,13 @@ TEST_F(RepeatableQueriesServiceTest, SignedIn_DefaultSearchProviderChanged) {
EXPECT_TRUE(service()->repeatable_queries().empty());
}
TEST_F(RepeatableQueriesServiceTest, SignedIn_SigninStatusChanged) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn_SigninStatusChanged DISABLED_SignedIn_SigninStatusChanged
#else
#define MAYBE_SignedIn_SigninStatusChanged SignedIn_SigninStatusChanged
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedIn_SigninStatusChanged) {
base::HistogramTester histogram_tester;
SignIn();
......@@ -511,7 +529,13 @@ TEST_F(RepeatableQueriesServiceTest, SignedIn_SigninStatusChanged) {
RepeatableQueriesService::kExtractedCountHistogram, 2, 1);
}
TEST_F(RepeatableQueriesServiceTest, SignedIn_Deletion) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedIn_Deletion DISABLED_SignedIn_Deletion
#else
#define MAYBE_SignedIn_Deletion SignedIn_Deletion
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedIn_Deletion) {
SignIn();
test_url_loader_factory()->AddResponse(service()->GetRequestURL().spec(),
GoodServerResponse());
......@@ -563,7 +587,7 @@ TEST_F(RepeatableQueriesServiceTest, SignedIn_Deletion) {
EXPECT_EQ(expected_server_queries, service()->repeatable_queries());
}
// TODO(crbug.com/1150909) Test fails on iOS simulators
// TODO(crbug.com/1151909) Test fails on iOS simulators
#if defined(OS_IOS)
#define MAYBE_SignedOut_DefaultSearchProviderChanged \
DISABLED_SignedOut_DefaultSearchProviderChanged
......@@ -609,7 +633,14 @@ TEST_F(RepeatableQueriesServiceTest,
EXPECT_TRUE(service()->repeatable_queries().empty());
}
TEST_F(RepeatableQueriesServiceTest, SignedOut_SigninStatusChanged) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedOut_SigninStatusChanged \
DISABLED_SignedOut_SigninStatusChanged
#else
#define MAYBE_SignedOut_SigninStatusChanged SignedOut_SigninStatusChanged
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedOut_SigninStatusChanged) {
int original_query_age =
history::kAutocompleteDuplicateVisitIntervalThreshold.InSeconds() + 3;
FillURLDatabase({
......@@ -652,7 +683,13 @@ TEST_F(RepeatableQueriesServiceTest, SignedOut_SigninStatusChanged) {
EXPECT_EQ(expected_server_queries, service()->repeatable_queries());
}
TEST_F(RepeatableQueriesServiceTest, SignedOut_Deletion) {
// TODO(crbug.com/1151909) Test fails on iOS
#if defined(OS_IOS)
#define MAYBE_SignedOut_Deletion DISABLED_SignedOut_Deletion
#else
#define MAYBE_SignedOut_Deletion SignedOut_Deletion
#endif
TEST_F(RepeatableQueriesServiceTest, MAYBE_SignedOut_Deletion) {
FillURLDatabase({{default_search_provider(), "local query 1",
/*age_in_seconds=*/1},
{default_search_provider(), "local query 2",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment