Commit f6c69102 authored by Stepan Khapugin's avatar Stepan Khapugin Committed by Commit Bot

Dismiss the keyboard even when having no suggestions.

This is useful when you only have the shortcuts, but no results, and
you can't see them all (in landscape).

Bug: 931210, 906054
Test: 1. Enable Shortcuts flag. Navigate to any URL. Scroll the popup
area. Keyboard should be dismissed. 2. Same steps, but clear the text
field (see issue 906054) before scrolling. The omnibox should be empty,
the Cancel button should be visible, the keyboard should be dismissed.

Change-Id: Ibd1637d17536e13352ec0a3b1f872b6df8aed714
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491272
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638200}
parent 6d112355
...@@ -570,11 +570,6 @@ UIColor* BackgroundColorIncognito() { ...@@ -570,11 +570,6 @@ UIColor* BackgroundColorIncognito() {
if (!scrollView.dragging) if (!scrollView.dragging)
return; return;
if (!_currentResult.count) {
// No need to dismiss the keyboard when there are no results.
return;
}
// TODO(crbug.com/911534): The following call chain ultimately just dismisses // TODO(crbug.com/911534): The following call chain ultimately just dismisses
// the keyboard, but involves many layers of plumbing, and should be // the keyboard, but involves many layers of plumbing, and should be
// refactored. // refactored.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment