Commit f6d280bc authored by Natalie Chouinard's avatar Natalie Chouinard Committed by Commit Bot

Remove pixel diff thresholds on NTP tests

Now that render tests are disabled on Android CFI bot
(crrev.com/c/2154730), remove pixel diff thresholds that were added to
address those failures.

Bug: 1068294
Change-Id: I3ef98cfec4e183c54bf3c754089a2463282e634c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155011Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760223}
parent 7fd6fb59
...@@ -96,9 +96,6 @@ import java.util.List; ...@@ -96,9 +96,6 @@ import java.util.List;
mNtp = (FeedNewTabPage) mTab.getNativePage(); mNtp = (FeedNewTabPage) mTab.getNativePage();
mTileGridLayout = mNtp.getView().findViewById(R.id.tile_grid_layout); mTileGridLayout = mNtp.getView().findViewById(R.id.tile_grid_layout);
Assert.assertEquals(mSiteSuggestions.size(), mTileGridLayout.getChildCount()); Assert.assertEquals(mSiteSuggestions.size(), mTileGridLayout.getChildCount());
// Set 10 diff threshold. It is a value in RGBA channel, not pixel count.
mRenderTestRule.setPixelDiffThreshold(10);
} }
@Test @Test
......
...@@ -185,9 +185,6 @@ public class NewTabPageTest { ...@@ -185,9 +185,6 @@ public class NewTabPageTest {
mFakebox = mNtp.getView().findViewById(R.id.search_box); mFakebox = mNtp.getView().findViewById(R.id.search_box);
mTileGridLayout = mNtp.getView().findViewById(R.id.tile_grid_layout); mTileGridLayout = mNtp.getView().findViewById(R.id.tile_grid_layout);
Assert.assertEquals(mSiteSuggestions.size(), mTileGridLayout.getChildCount()); Assert.assertEquals(mSiteSuggestions.size(), mTileGridLayout.getChildCount());
// TODO(crbug.com/1068294): Remove the following line if this general issue is fixed.
mRenderTestRule.setPixelDiffThreshold(10);
} }
@After @After
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment