Commit f6daa30a authored by nbarth@chromium.org's avatar nbarth@chromium.org

Turn conditionals back on in aggregate bindings

Aggregate bindings are supposed to wrap the include of
interfaces that have [Conditional] on their definition with
ifdef, so these are not compiled if these are turned off.

However, this was broken so it didn't work,
and we couldn't turn it on, due to linking failure in SVG.
(I noticed this during a cleanup.)

This now can be turned back on, perhaps thanks to Kouhei's
fix-up of SVG bindings (or something Mahesh has been doing?).
Turning it on thus speeds up and simplifies compilation
somewhat.

(The only [Conditional] compilation flags on interfaces
are SVG_FONTS and WEB_AUDIO.)

I looked into this because of Mahesh's other Conditional fixes in:
Add support in generate scripts to handle Conditional
https://codereview.chromium.org/330093002/

R=haraken

Review URL: https://codereview.chromium.org/333803003

git-svn-id: svn://svn.chromium.org/blink/trunk@176092 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent d5997868
......@@ -156,9 +156,7 @@ def generate_content(component_dir, files_meta_data_this_partition):
prev_conditional = None
files_meta_data_this_partition.sort(key=lambda e: e['conditional'])
for meta_data in files_meta_data_this_partition:
# FIXME: linking fails (in SVG) if conditionals occur
# conditional = meta_data['conditional']
conditional = None
conditional = meta_data['conditional']
if prev_conditional != conditional:
if prev_conditional:
output.append('#endif\n')
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment