Make v8_context_snapshot as data_deps

v8_context_snapshot is not the target to be linked to other libraries.

This improves build time of some targets by utilize parallelization.
For example, build time of -j800 content_shell reduced from 316.8s to 254.5s on Z840 linux without goma backend cache.

See the difference of build trace screenshots in
https://bugs.chromium.org/p/chromium/issues/detail?id=725639#c20

Bug: 725639
Change-Id: I64d57241ff6b742db4ddcb31afc07a5e7c2e2eb1
Reviewed-on: https://chromium-review.googlesource.com/1107431Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569207}

content/shell/BUILD.gn

@@ -573,9 +573,6 @@ if (is_android) {
 
     data_deps = [
       ":pak",
-    ]
-
-    public_deps = [
       "//tools/v8_context_snapshot:v8_context_snapshot",
     ]
 

content/test/BUILD.gn

@@ -306,7 +306,6 @@ jumbo_static_library("test_support") {
     "//media/mojo/interfaces",
     "//third_party/blink/public:blink",
     "//third_party/blink/public:test_support",
-    "//tools/v8_context_snapshot",
   ]
   deps = [
     ":content_test_mojo_bindings",
@@ -364,7 +363,6 @@ jumbo_static_library("test_support") {
     "//third_party/webrtc/rtc_base:rtc_base_approved",
     "//third_party/webrtc/stats:rtc_stats",
     "//third_party/webrtc_overrides:init_webrtc",
-    "//tools/v8_context_snapshot:v8_context_snapshot",
     "//ui/accessibility:ax_enums_mojo",
     "//ui/base",
     "//ui/base:test_support",
@@ -389,6 +387,7 @@ jumbo_static_library("test_support") {
 
   data_deps = [
     "//content/shell:pak",
+    "//tools/v8_context_snapshot:v8_context_snapshot",
   ]
 
   if (is_android) {

gin/BUILD.gn

@@ -148,7 +148,6 @@ test("gin_unittests") {
     "//base/test:test_support",
     "//testing/gmock",
     "//testing/gtest",
-    "//tools/v8_context_snapshot:v8_context_snapshot",
     "//v8",
   ]
 
@@ -157,7 +156,9 @@ test("gin_unittests") {
     "//v8:external_startup_data",
   ]
 
-  data_deps = []
+  data_deps = [
+    "//tools/v8_context_snapshot:v8_context_snapshot",
+  ]
   data = []
 
   # gin_shell is not an Android app.

services/data_decoder/BUILD.gn

@@ -56,10 +56,13 @@ source_set("tests") {
     "//skia",
     "//testing/gtest",
     "//third_party/blink/public:blink",
-    "//tools/v8_context_snapshot",
     "//ui/gfx",
   ]
 
+  data_deps = [
+    "//tools/v8_context_snapshot",
+  ]
+
   configs += [
     "//tools/v8_context_snapshot:use_v8_context_snapshot",
     "//v8:external_startup_data",