Commit f6ea9964 authored by Xiaohui Chen's avatar Xiaohui Chen Committed by Commit Bot

ambient: fix flaky media string view tests

These tests rely on automatically view layout scheduling, which
seems unreliable. Now force explicit re-layout.

Bug: b:169442907
Test: run ash_unittests
Change-Id: I5287ba293eba77b820d8e59b456feb32fb71a920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442640Reviewed-by: default avatarTao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812840}
parent 4512f77b
...@@ -6,6 +6,7 @@ ...@@ -6,6 +6,7 @@
#include "ash/ambient/ambient_constants.h" #include "ash/ambient/ambient_constants.h"
#include "ash/ambient/test/ambient_ash_test_base.h" #include "ash/ambient/test/ambient_ash_test_base.h"
#include "ash/ambient/ui/ambient_container_view.h"
#include "ash/public/cpp/ash_pref_names.h" #include "ash/public/cpp/ash_pref_names.h"
#include "ash/shell.h" #include "ash/shell.h"
#include "base/strings/string16.h" #include "base/strings/string16.h"
...@@ -260,8 +261,8 @@ TEST_F(MediaStringViewTest, HasNoMaskLayerWithShortText) { ...@@ -260,8 +261,8 @@ TEST_F(MediaStringViewTest, HasNoMaskLayerWithShortText) {
metadata.artist = base::ASCIIToUTF16("artist"); metadata.artist = base::ASCIIToUTF16("artist");
SimulateMediaMetadataChanged(metadata); SimulateMediaMetadataChanged(metadata);
// Wait for layout. // Force re-layout.
task_environment()->FastForwardBy(base::TimeDelta::FromMilliseconds(100)); container_view()->Layout();
EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(), EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(),
kMediaStringMaxWidthDip); kMediaStringMaxWidthDip);
...@@ -277,8 +278,8 @@ TEST_F(MediaStringViewTest, HasMaskLayerWithLongText) { ...@@ -277,8 +278,8 @@ TEST_F(MediaStringViewTest, HasMaskLayerWithLongText) {
metadata.artist = base::ASCIIToUTF16("A super duper long artist name"); metadata.artist = base::ASCIIToUTF16("A super duper long artist name");
SimulateMediaMetadataChanged(metadata); SimulateMediaMetadataChanged(metadata);
// Wait for layout. // Force re-layout.
task_environment()->FastForwardBy(base::TimeDelta::FromMilliseconds(100)); container_view()->Layout();
EXPECT_GT(GetMediaStringViewTextLabel()->GetPreferredSize().width(), EXPECT_GT(GetMediaStringViewTextLabel()->GetPreferredSize().width(),
kMediaStringMaxWidthDip); kMediaStringMaxWidthDip);
...@@ -294,8 +295,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) { ...@@ -294,8 +295,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) {
metadata.artist = base::ASCIIToUTF16("artist"); metadata.artist = base::ASCIIToUTF16("artist");
SimulateMediaMetadataChanged(metadata); SimulateMediaMetadataChanged(metadata);
// Wait for layout. // Force re-layout.
task_environment()->FastForwardBy(base::TimeDelta::FromMilliseconds(100)); container_view()->Layout();
EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(), EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(),
kMediaStringMaxWidthDip); kMediaStringMaxWidthDip);
...@@ -306,8 +307,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) { ...@@ -306,8 +307,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) {
metadata.artist = base::ASCIIToUTF16("A super duper long artist name"); metadata.artist = base::ASCIIToUTF16("A super duper long artist name");
SimulateMediaMetadataChanged(metadata); SimulateMediaMetadataChanged(metadata);
// Wait for layout. // Force re-layout.
task_environment()->FastForwardBy(base::TimeDelta::FromMilliseconds(100)); container_view()->Layout();
EXPECT_GT(GetMediaStringViewTextLabel()->GetPreferredSize().width(), EXPECT_GT(GetMediaStringViewTextLabel()->GetPreferredSize().width(),
kMediaStringMaxWidthDip); kMediaStringMaxWidthDip);
...@@ -318,8 +319,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) { ...@@ -318,8 +319,8 @@ TEST_F(MediaStringViewTest, MaskLayerShouldUpdate) {
metadata.artist = base::ASCIIToUTF16("artist"); metadata.artist = base::ASCIIToUTF16("artist");
SimulateMediaMetadataChanged(metadata); SimulateMediaMetadataChanged(metadata);
// Wait for layout. // Force re-layout.
task_environment()->FastForwardBy(base::TimeDelta::FromMilliseconds(100)); container_view()->Layout();
EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(), EXPECT_LT(GetMediaStringViewTextLabel()->GetPreferredSize().width(),
kMediaStringMaxWidthDip); kMediaStringMaxWidthDip);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment