Commit f7029413 authored by enne's avatar enne Committed by Commit bot

Turn off verification for property trees

As a part of staging the launch of property trees for the compositor
thread, first turn off verification entirely.  The next steps are to
locally fix problems when verification is on for the compositor thread,
and then turn it back on.

Another option would be separate main/compositor thread verification
flags, but that's more complicated.  Additionally, main thread
verification does very little except in a few cc unit tests, as
launching main thread property trees disabled most verification.

Depends on https://codereview.chromium.org/1136643006.

R=ajuma@chromium.org,vollick@chromium.org,mkwst@chromium.org
BUG=481585

Review URL: https://codereview.chromium.org/1134753005

Cr-Commit-Position: refs/heads/master@{#330608}
parent 4f119d8b
......@@ -17,7 +17,6 @@ FakeLayerTreeHost::FakeLayerTreeHost(FakeLayerTreeHostClient* client,
scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create(
FakeLayerTreeHostClient* client) {
LayerTreeSettings settings;
settings.verify_property_trees = true;
return Create(client, settings);
}
......
......@@ -532,7 +532,7 @@ LayerTreeTest::LayerTreeTest()
started_(false),
ended_(false),
delegating_renderer_(false),
verify_property_trees_(true),
verify_property_trees_(false),
timeout_seconds_(0),
weak_factory_(this) {
main_thread_weak_ptr_ = weak_factory_.GetWeakPtr();
......
......@@ -263,7 +263,7 @@ LayerTreeHostCommon::CalcDrawPropsInputsForTesting<LayerType,
false,
true,
false,
true,
false,
render_surface_layer_list,
0,
GetPropertyTrees(root_layer, &temporary_property_trees)) {
......@@ -292,7 +292,7 @@ LayerTreeHostCommon::CalcDrawPropsInputsForTesting<LayerType,
false,
true,
false,
true,
false,
render_surface_layer_list,
0,
GetPropertyTrees(root_layer, &temporary_property_trees)) {
......
......@@ -103,7 +103,7 @@ class LayerTreeHostNoMessageLoopTest
void SetupLayerTreeHost() {
LayerTreeSettings settings;
settings.single_thread_proxy_scheduler = false;
settings.verify_property_trees = true;
settings.verify_property_trees = false;
settings.raster_enabled = false;
LayerTreeHost::InitParams params;
......
......@@ -195,8 +195,6 @@ bool ShellMainDelegate::BasicStartupComplete(int* exit_code) {
command_line.AppendSwitch(switches::kDisableDelegatedRenderer);
command_line.AppendSwitch(cc::switches::kCompositeToMailbox);
command_line.AppendSwitch(cc::switches::kEnablePropertyTreeVerification);
command_line.AppendSwitch(switches::kEnablePreciseMemoryInfo);
command_line.AppendSwitchASCII(switches::kHostResolverRules,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment