Fix notifications tests' use of assert_object_equals

Several notifications layout tests misues assert_object_equals, passing
in non-object values, and assuming it will behave like assert_equals.

Spoiler - it doesn't: assert_object_equals(true, false) passes!

BUG=none

Review URL: https://codereview.chromium.org/1321643002

git-svn-id: svn://svn.chromium.org/blink/trunk@201317 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/LayoutTests/http/tests/notifications/notification-data-property.html

@@ -14,10 +14,8 @@
     function assertNotificationDataReflects(value) {
         var notification = new Notification('Title', { data: value });
 
-        if (Array.isArray(value))
+        if (typeof value === 'object')
             assert_object_equals(notification.data, value);
-        else if (typeof value === 'object')
-            assert_array_equals(notification.data, value);
         else
             assert_equals(notification.data, value);
     }

third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-data-reflection.html

@@ -21,7 +21,6 @@
           var notificationDataList = new Array(
               true, // Check Boolean type
               1024, // Check Number type
-              Number.NaN, // Check Number.NaN type
               'any data', // Check String type
               new Array('Saab', 'Volvo', 'BMW'),  // Check Array type
               { first: 'first', second: 'second' }  // Check object
@@ -64,10 +63,13 @@
 
                   var pos = event.data.notification.tag;
 
-                  assert_object_equals(event.data.notification.data, notificationDataList[pos], 'The data field must be the same.');
+                  if (typeof notificationDataList[pos] === 'object')
+                      assert_object_equals(event.data.notification.data, notificationDataList[pos], 'The data field must be the same.');
+                  else
+                      assert_equals(event.data.notification.data, notificationDataList[pos], 'The data field must be the same.');
 
-                  if (pos < notificationDataList.length)
-                      assertNotificationDataReflects(++pos);
+                  if (++pos < notificationDataList.length)
+                      assertNotificationDataReflects(pos);
                   else
                       test.done();
               });

third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html

@@ -68,11 +68,12 @@
                   // set on the Notification object are as expected.
                   assert_equals(event.data.command, 'click', 'The notification was expected to be clicked.');
 
+                  options.actions = options.actions.slice(0, Notification.maxActions);
                   Object.keys(options).forEach(function(key) {
-                      if (key == 'actions')
-                          assert_object_equals(event.data.notification.actions, options.actions.slice(0, Notification.maxActions));
-                      else
+                      if (typeof options[key] == 'object')
                           assert_object_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
+                      else
+                          assert_equals(event.data.notification[key], options[key], 'The ' + key + ' field must be the same.');
                   });
 
                   test.done();