Commit f737318f authored by Alice Wang's avatar Alice Wang Committed by Chromium LUCI CQ

[Signin][Modularization] Move AccountPickerFeatureUtils to signin.ui target

This CL moves AccountPickerFeatureUtils to signin.ui target.

Bug: 1157822
Change-Id: I6094021754e9197ad71b63f5299a6d685e92095a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584927
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#836567}
parent a996cf1b
...@@ -1264,7 +1264,6 @@ chrome_java_sources = [ ...@@ -1264,7 +1264,6 @@ chrome_java_sources = [
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerCoordinator.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerCoordinator.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerDelegate.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerDelegate.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerDelegateImpl.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerDelegateImpl.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerFeatureUtils.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerMediator.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerMediator.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerProperties.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AccountPickerProperties.java",
"java/src/org/chromium/chrome/browser/signin/account_picker/AddAccountRowViewBinder.java", "java/src/org/chromium/chrome/browser/signin/account_picker/AddAccountRowViewBinder.java",
......
...@@ -21,6 +21,7 @@ import androidx.recyclerview.widget.RecyclerView; ...@@ -21,6 +21,7 @@ import androidx.recyclerview.widget.RecyclerView;
import org.chromium.chrome.R; import org.chromium.chrome.R;
import org.chromium.chrome.browser.signin.account_picker.AccountPickerBottomSheetProperties.ViewState; import org.chromium.chrome.browser.signin.account_picker.AccountPickerBottomSheetProperties.ViewState;
import org.chromium.chrome.browser.signin.services.DisplayableProfileData; import org.chromium.chrome.browser.signin.services.DisplayableProfileData;
import org.chromium.chrome.browser.signin.ui.account_picker.AccountPickerFeatureUtils;
import org.chromium.components.browser_ui.bottomsheet.BottomSheetContent; import org.chromium.components.browser_ui.bottomsheet.BottomSheetContent;
import org.chromium.ui.widget.ButtonCompat; import org.chromium.ui.widget.ButtonCompat;
......
...@@ -9,6 +9,7 @@ android_library("java") { ...@@ -9,6 +9,7 @@ android_library("java") {
":java_resources", ":java_resources",
"//base:base_java", "//base:base_java",
"//chrome/browser/consent_auditor/android:java", "//chrome/browser/consent_auditor/android:java",
"//chrome/browser/flags:java",
"//chrome/browser/profiles/android:java", "//chrome/browser/profiles/android:java",
"//chrome/browser/signin/services/android:java", "//chrome/browser/signin/services/android:java",
"//components/browser_ui/settings/android:java", "//components/browser_ui/settings/android:java",
...@@ -33,6 +34,7 @@ android_library("java") { ...@@ -33,6 +34,7 @@ android_library("java") {
"java/src/org/chromium/chrome/browser/signin/ui/SigninActivityLauncher.java", "java/src/org/chromium/chrome/browser/signin/ui/SigninActivityLauncher.java",
"java/src/org/chromium/chrome/browser/signin/ui/SigninScrollView.java", "java/src/org/chromium/chrome/browser/signin/ui/SigninScrollView.java",
"java/src/org/chromium/chrome/browser/signin/ui/SigninView.java", "java/src/org/chromium/chrome/browser/signin/ui/SigninView.java",
"java/src/org/chromium/chrome/browser/signin/ui/account_picker/AccountPickerFeatureUtils.java",
] ]
resources_package = "org.chromium.chrome.browser.signin.ui" resources_package = "org.chromium.chrome.browser.signin.ui"
} }
......
...@@ -2,19 +2,24 @@ ...@@ -2,19 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
package org.chromium.chrome.browser.signin.account_picker; package org.chromium.chrome.browser.signin.ui.account_picker;
import org.chromium.chrome.browser.flags.ChromeFeatureList; import org.chromium.chrome.browser.flags.ChromeFeatureList;
/** /**
* This class is used to handle state of feature flags in the project * This class is used to handle state of feature flags in the project
* MobileIdentityConsistency. * MobileIdentityConsistency.
*
* TODO(crbug.com/1155123): Change the class to package private after modularization
*/ */
class AccountPickerFeatureUtils { public class AccountPickerFeatureUtils {
private static final String DISMISS_BUTTON_PARAM = "dismiss_button"; private static final String DISMISS_BUTTON_PARAM = "dismiss_button";
private static final String HIDE_DISMISS_BUTTON = "hide"; private static final String HIDE_DISMISS_BUTTON = "hide";
static boolean shouldHideDismissButton() { /**
* TODO(crbug.com/1155123): Change the method to package private after modularization
*/
public static boolean shouldHideDismissButton() {
return HIDE_DISMISS_BUTTON.equals(ChromeFeatureList.getFieldTrialParamByFeature( return HIDE_DISMISS_BUTTON.equals(ChromeFeatureList.getFieldTrialParamByFeature(
ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY_VAR, DISMISS_BUTTON_PARAM)); ChromeFeatureList.MOBILE_IDENTITY_CONSISTENCY_VAR, DISMISS_BUTTON_PARAM));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment