Commit f743efe7 authored by Anthony Cui's avatar Anthony Cui Committed by Commit Bot

Allow translation of unknown source language page on desktop only

Bug: 1139799
Change-Id: I23a4c92316b47b1d95240702a758e799a00d05a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488368
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: default avatarScott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819495}
parent 11e6c88b
......@@ -213,9 +213,14 @@ bool TranslateManager::CanManuallyTranslate() {
return false;
const std::string source_language = language_state_.original_language();
if (source_language.empty() ||
source_language == translate::kUnknownLanguageCode)
if (source_language.empty())
return false;
// Translation of unknown source language pages is supported on desktop
// platforms, but not mobile.
#if defined(OS_ANDROID) || defined(OS_IOS)
if (source_language == translate::kUnknownLanguageCode)
return false;
#endif
std::unique_ptr<TranslatePrefs> translate_prefs(
translate_client_->GetTranslatePrefs());
......
......@@ -1019,7 +1019,13 @@ TEST_F(TranslateManagerTest, CanManuallyTranslate_UndefinedSourceLanguage) {
translate_manager_->GetLanguageState()->LanguageDetermined(
translate::kUnknownLanguageCode, true);
// Translation of unknown source language pages is supported on desktop
// platforms, but not mobile.
#if defined(OS_ANDROID) || defined(OS_IOS)
EXPECT_FALSE(translate_manager_->CanManuallyTranslate());
#else
EXPECT_TRUE(translate_manager_->CanManuallyTranslate());
#endif
}
TEST_F(TranslateManagerTest, PredefinedTargetLanguage) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment