IDL parser: Drop support of 2 legacy keywords

Now we don't use keywords "creator" nor "legacycaller".
This CL drops these legacy keywords and reconstruct the parsing
patterns.  This change does not change output ASTs, as a result.

The new pattern ignores OperationNameKeyword to allow "includes"
as an operation's name, because the case is cought by the leading
"_" rule.

cf. https://github.com/heycam/webidl/issues/767



Bug: 839389
Change-Id: Idccb1853a82d629504464f0dad5fbe82702c083d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809134Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#697519}

tools/idl_parser/idl_lexer.py

@@ -60,7 +60,6 @@ class IDLLexer(object):
     'ByteString' : 'BYTESTRING',
     'callback' : 'CALLBACK',
     'const' : 'CONST',
-    'creator' : 'CREATOR',
     'deleter' : 'DELETER',
     'dictionary' : 'DICTIONARY',
     'DOMString' : 'DOMSTRING',
@@ -75,7 +74,6 @@ class IDLLexer(object):
     'inherit' : 'INHERIT',
     'interface' : 'INTERFACE',
     'iterable': 'ITERABLE',
-    'legacycaller' : 'LEGACYCALLER',
     'long' : 'LONG',
     'maplike': 'MAPLIKE',
     'mixin': 'MIXIN',

tools/idl_parser/idl_parser.py

@@ -271,14 +271,12 @@ class IDLParser(object):
     """ArgumentNameKeyword : ATTRIBUTE
                            | CALLBACK
                            | CONST
-                           | CREATOR
                            | DELETER
                            | DICTIONARY
                            | ENUM
                            | GETTER
                            | INCLUDES
                            | INHERIT
-                           | LEGACYCALLER
                            | NAMESPACE
                            | PARTIAL
                            | SETTER
@@ -509,41 +507,34 @@ class IDLParser(object):
       p[0] = p[1]
 
   def p_Operation(self, p):
-    """Operation : ReturnType OperationRest
+    """Operation : RegularOperation
                  | SpecialOperation"""
-    if len(p) == 3:
-      p[2].AddChildren(p[1])
-      p[0] = p[2]
-    else:
-      p[0] = p[1]
+    p[0] = p[1]
 
-  def p_SpecialOperation(self, p):
-    """SpecialOperation : Special Specials ReturnType OperationRest"""
-    p[4].AddChildren(ListFromConcat(p[1], p[2], p[3]))
-    p[0] = p[4]
+  def p_RegularOperation(self, p):
+    """RegularOperation : ReturnType OperationRest"""
+    p[2].AddChildren(p[1])
+    p[0] = p[2]
 
-  def p_Specials(self, p):
-    """Specials : Special Specials
-                | """
-    if len(p) > 1:
-      p[0] = ListFromConcat(p[1], p[2])
+  def p_SpecialOperation(self, p):
+    """SpecialOperation : Special RegularOperation"""
+    p[2].AddChildren(p[1])
+    p[0] = p[2]
 
   def p_Special(self, p):
     """Special : GETTER
                | SETTER
-               | CREATOR
-               | DELETER
-               | LEGACYCALLER"""
+               | DELETER"""
     p[0] = self.BuildTrue(p[1].upper())
 
   def p_OperationRest(self, p):
-    """OperationRest : OptionalIdentifier '(' ArgumentList ')' ';'"""
+    """OperationRest : OptionalOperationName '(' ArgumentList ')' ';'"""
     arguments = self.BuildProduction('Arguments', p, 2, p[3])
     p[0] = self.BuildNamed('Operation', p, 1, arguments)
 
-  def p_OptionalIdentifier(self, p):
-    """OptionalIdentifier : identifier
-                          |"""
+  def p_OptionalOperationName(self, p):
+    """OptionalOperationName : identifier
+                             |"""
     if len(p) > 1:
       p[0] = p[1]
     else:

tools/idl_parser/test_lexer/keywords.in

@@ -5,7 +5,6 @@ BYTESTRING ByteString
 BYTE byte
 CALLBACK callback
 CONST const
-CREATOR creator
 DELETER deleter
 DICTIONARY dictionary
 DOMSTRING DOMString
@@ -18,7 +17,6 @@ INFINITY Infinity
 INHERIT inherit
 INTERFACE interface
 ITERABLE iterable
-LEGACYCALLER legacycaller
 LONG long
 MAPLIKE maplike
 MIXIN mixin

tools/idl_parser/test_parser/interface_web.idl

@@ -271,7 +271,6 @@ interface MyIFaceBig {
 /** TREE
  *Interface(MyIFaceSpecials)
  *  Operation(set)
- *    CREATOR: True
  *    SETTER: True
  *    Arguments()
  *      Argument(property)
@@ -289,7 +288,7 @@ interface MyIFaceBig {
  *      PrimitiveType(double)
  */
 interface MyIFaceSpecials {
-  setter creator void set(DOMString property);
+  setter void set(DOMString property);
   getter double (DOMString property);
 };